Add caching functionality

mikebronner · mikebronner · commit 73f6f8bd2192 · 2017-06-17T17:52:35.000-07:00
diff --git a/config/geocoder.php b/config/geocoder.php
@@ -18,6 +18,7 @@
 use Geocoder\Provider\MaxMindBinary;
 
 return [
+    'cache-duraction' => 999999999,
     'providers' => [
         Chain::class => [
             GoogleMaps::class => [
diff --git a/src/ProviderAndDumperAggregator.php b/src/ProviderAndDumperAggregator.php
@@ -73,7 +73,14 @@ public function dump($dumper)
      */
     public function geocode($value)
     {
-        $this->results = parent::geocode($value);
+        $cacheId = str_slug($value);
+        $this->results = cache()->remember(
+            "geocoder-{$cacheId}",
+            config('geocoder.cache-duraction', 0),
+            function () use ($value) {
+                return parent::geocode($value);
+            }
+        );
 
         return $this;
     }
@@ -93,7 +100,14 @@ public function get()
      */
     public function reverse($latitude, $longitude)
     {
-        $this->results = parent::reverse($latitude, $longitude);
+        $cacheId = str_slug("{$latitude}-{$longitude}");
+        $this->results = cache()->remember(
+            "geocoder-{$cacheId}",
+            config('geocoder.cache-duraction', 0),
+            function () use ($latitude, $longitude) {
+                return parent::reverse($latitude, $longitude);
+            }
+        );
 
         return $this;
     }
diff --git a/tests/Laravel5_3/Providers/GeocoderServiceTest.php b/tests/Laravel5_3/Providers/GeocoderServiceTest.php
@@ -173,4 +173,14 @@ public function testGeocoder()
     {
         $this->assertInstanceOf(ProviderAndDumperAggregator::class, app('geocoder'));
     }
+
+    public function testCacheIsUsed()
+    {
+        $result = app('geocoder')->geocode('1600 Pennsylvania Ave., Washington, DC USA')
+            ->get();
+        $cacheKey = 'geocoder-' . str_slug('1600 Pennsylvania Ave., Washington, DC USA');
+
+        $this->assertTrue(cache()->has($cacheKey));
+        $this->assertEquals($result, cache($cacheKey));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -173,4 +173,14 @@ public function testGeocoder()`
`173`	`173`	`{`
`174`	`174`	`$this->assertInstanceOf(ProviderAndDumperAggregator::class, app('geocoder'));`
`175`	`175`	`}`
	`176`	`+`
	`177`	`+ public function testCacheIsUsed()`
	`178`	`+ {`
	`179`	`+ $result = app('geocoder')->geocode('1600 Pennsylvania Ave., Washington, DC USA')`
	`180`	`+ ->get();`
	`181`	`+ $cacheKey = 'geocoder-' . str_slug('1600 Pennsylvania Ave., Washington, DC USA');`
	`182`	`+`
	`183`	`+ $this->assertTrue(cache()->has($cacheKey));`
	`184`	`+ $this->assertEquals($result, cache($cacheKey));`
	`185`	`+ }`
`176`	`186`	`}`