Skip to content

Commit d93d903

Browse files
author
Ilya Shtricul
committed
Fixed tests
1 parent 3a7841d commit d93d903

File tree

2 files changed

+28
-15
lines changed

2 files changed

+28
-15
lines changed

tests/Facade/GeocoderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ public function testGeocoderFacade()
2020
{
2121
$this->assertTrue(is_array($providers = \Geocoder::getProviders()));
2222
$this->assertArrayHasKey('chain', $providers);
23-
$this->assertInstanceOf('Geocoder\\Provider\\ChainProvider', $providers['chain']);
23+
$this->assertInstanceOf('Geocoder\\Provider\\Chain', $providers['chain']);
2424
}
2525
}

tests/GeocoderServiceProviderTest.php

Lines changed: 27 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ class GeocoderServiceProviderTest extends TestCase
1919
public function testConfig()
2020
{
2121
$this->assertTrue(is_array($providers = $this->app['config']->get('geocoder.providers')));
22-
$this->assertCount(2, $providers);
23-
$this->assertArrayHasKey('Geocoder\\Provider\\GoogleMapsProvider', $providers);
24-
$this->assertArrayHasKey('Geocoder\\Provider\\FreeGeoIpProvider', $providers);
25-
$this->assertSame('Geocoder\\HttpAdapter\\CurlHttpAdapter', $this->app['config']->get('geocoder.adapter'));
22+
$this->assertCount(3, $providers);
23+
$this->assertArrayHasKey('Geocoder\\Provider\\GoogleMaps', $providers);
24+
$this->assertArrayHasKey('Geocoder\\Provider\\FreeGeoIp', $providers);
25+
$this->assertSame('Ivory\\HttpAdapter\\CurlHttpAdapter', $this->app['config']->get('geocoder.adapter'));
2626
}
2727

2828
public function testLoadedProviders()
@@ -35,25 +35,38 @@ public function testLoadedProviders()
3535

3636
public function testGeocoderDefaultAdapter()
3737
{
38-
$this->assertInstanceOf('Geocoder\\HttpAdapter\\CurlHttpAdapter', $this->app['geocoder.adapter']);
38+
$this->assertInstanceOf('Ivory\\HttpAdapter\\CurlHttpAdapter', $this->app['geocoder.adapter']);
3939
}
4040

4141
public function testGeocoderChainProvider()
4242
{
43-
$this->assertInstanceOf('Geocoder\\Provider\\ChainProvider', $this->app['geocoder.chain']);
43+
$providers = $this->getProtectedProperty($this->app['geocoder'], 'providers');
44+
45+
$this->assertArrayHasKey('chain', $providers);
46+
47+
$this->assertInstanceOf('Geocoder\\Provider\\Chain', $providers['chain']);
48+
49+
$chainProviders = $this->getProtectedProperty($providers['chain'], 'providers');
50+
51+
$this->assertInstanceOf('Geocoder\\Provider\\GoogleMaps', $chainProviders[0]);
52+
$this->assertSame('fr-FR', $chainProviders[0]->getLocale());
53+
$this->assertInstanceOf('Ivory\\HttpAdapter\\CurlHttpAdapter', $chainProviders[0]->getAdapter());
54+
55+
$this->assertInstanceOf('Geocoder\\Provider\\FreeGeoIp', $chainProviders[1]);
56+
$this->assertInstanceOf('Ivory\\HttpAdapter\\CurlHttpAdapter', $chainProviders[1]->getAdapter());
57+
4458
}
4559

46-
public function testGeocoderDefaultProvider()
60+
public function testGeocoderNamedProviders()
4761
{
48-
$providers = $this->getProtectedProperty($this->app['geocoder.chain'], 'providers');
62+
$providers = $this->getProtectedProperty($this->app['geocoder'], 'providers');
4963

50-
$this->assertInstanceOf('Geocoder\\Provider\\GoogleMapsProvider', $providers[0]);
51-
$this->assertSame('fr-FR', $providers[0]->getLocale());
52-
$this->assertInstanceOf('Geocoder\\HttpAdapter\\CurlHttpAdapter', $providers[0]->getAdapter());
64+
$this->assertInstanceOf('Geocoder\\Provider\\GoogleMaps', $providers['google_maps']);
65+
$this->assertSame('fr-FR', $providers['google_maps']->getLocale());
66+
$this->assertInstanceOf('Ivory\\HttpAdapter\\CurlHttpAdapter', $providers['google_maps']->getAdapter());
5367

54-
$this->assertInstanceOf('Geocoder\\Provider\\FreeGeoIpProvider', $providers[1]);
55-
$this->assertNull($providers[1]->getLocale());
56-
$this->assertInstanceOf('Geocoder\\HttpAdapter\\CurlHttpAdapter', $providers[1]->getAdapter());
68+
$this->assertInstanceOf('Geocoder\\Provider\\FreeGeoIp', $providers['free_geo_ip']);
69+
$this->assertInstanceOf('Ivory\\HttpAdapter\\CurlHttpAdapter', $providers['free_geo_ip']->getAdapter());
5770
}
5871

5972
public function testGeocoder()

0 commit comments

Comments
 (0)