You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in Geocoder.php config, set cache.duration = 15 (minutes per documentation)
clear Redis cache (no keys present)
execute a geocode() call, verify Redis shows 1 key
execute same geocode(), verify Redis shows a cache hit
Wait 20 seconds, verify Redis shows 0 keys
execute same geocode(), verify Redis key is again added
Stack Trace
n/a
Since the Caching change is a major and documented breaking issue in Laravel, I am not sure if it would be preferred to only make a documentation update in the "Cache Duration" section of the config file, or update the library to convert provided parameter in Minutes into Seconds for the caching calls. Since the latter would potentially introduce a breaking change to applications that have already been modified for Laravel 5.8+, the documentation update may be the best route.
Thanks for a very helpful library
The text was updated successfully, but these errors were encountered:
Hi @bcwaretx, thanks for reaching out! I'm a bit confused, though, as this package's cache configuration is already measured in seconds, as the documentation in the config file states. Can you clarify why you think it is in minutes?
General Information
GeocoderLaravel Version: 4.3
Laravel Version: 6.18.1 dev (Since 5.8)
PHP Version: 7.2.5+
Operating System and Version: MacOS 10.11 MAMP Pro 5.5
Issue Description
Beginning with Laravel 5.8, cache TTL is defined in Seconds rather than Minutes. This was identified as a major breaking change:
https://laravel.com/docs/5.8/upgrade#cache-ttl-in-seconds
laravel/framework#27276
Steps to Replicate
Stack Trace
n/a
Since the Caching change is a major and documented breaking issue in Laravel, I am not sure if it would be preferred to only make a documentation update in the "Cache Duration" section of the config file, or update the library to convert provided parameter in Minutes into Seconds for the caching calls. Since the latter would potentially introduce a breaking change to applications that have already been modified for Laravel 5.8+, the documentation update may be the best route.
Thanks for a very helpful library
The text was updated successfully, but these errors were encountered: