Skip to content

MaxmindBinaryProvider is being instantiated with an adapter instance, which it does not expect #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhughes opened this issue May 27, 2015 · 1 comment
Closed

MaxmindBinaryProvider is being instantiated with an adapter instance, which it does not expect #24

mhughes opened this issue May 27, 2015 · 1 comment
Assignees
@mikebronner
Labels
bug
Milestone
1.0.0

Comments

@mhughes
Copy link

mhughes commented May 27, 2015 •
edited by mikebronner
Loading

The geocoder service provider instantiates an http adapter which MaxmindBinaryProvider does not expect nor require, as the first parameter on the constructor. I'll be submitting a workaround in a pull request later.
@mikebronner mikebronner added this to the 0.7 milestone Sep 30, 2016
@mikebronner mikebronner self-assigned this Sep 30, 2016
@mikebronner
Copy link
Member

This should be fixed in the next release, if it does happen again, please reopen this issue.

@alexc-hollywood alexc-hollywood mentioned this issue Jun 13, 2017
Closed
@foziazahoor foziazahoor mentioned this issue Aug 3, 2017
Closed
@darkcast64 darkcast64 mentioned this issue Aug 22, 2019
Closed
@sheinfeld sheinfeld mentioned this issue Mar 4, 2020
Closed
@devs-ryan devs-ryan mentioned this issue Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikebronner mikebronner

Labels
bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@mhughes @mikebronner