Skip to content

Update geocode #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bingalls opened this issue Oct 6, 2016 · 1 comment
Closed

Update geocode #50

bingalls opened this issue Oct 6, 2016 · 1 comment
Labels
duplicate

Comments

@bingalls
Copy link

bingalls commented Oct 6, 2016 •
edited by mikebronner
Loading

In short: GeocoderLaravel v0.6 uses an obsolete GuzzleHttp v3 library.
Details:
The latest stable "toin0u/geocoder-laravel": "^0.6.0" requires years-old "willdurand/geocoder" : "~2.4"
This old version of geocoder has an old Geocoder/HttpAdapter/GuzzleHttpAdapter.php that calls
use Guzzle\Service\Client;
This is old Guzzle 3.0 code
http://mtdowling.com/blog/2012/10/16/guzzle-3-dot-0-better-service-descriptions-and-more-modular/
Which, as explained in the current v6.x README.md is End Of Life.
This conflicts with other code, that runs a maintained version of GuzzleHttp lib.

Also note that the composer.json description field for "toin0u/geocoder-laravel": "^0.6.0" confusingly mentions Laravel v4, even though it requires
"illuminate/support" : "~5.0"

This looks like it has been fixed in feature/update-for-laravel-5-3
If you could rename this branch with a dev- prefix, it would be accessible via Composer:
https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository
@mikebronner
Copy link
Member

Hi @bingalls, we're working hard on getting this out sooner than later. You can access the feature branch in composer using the following syntax:

"require": {
  "toin0u/geocoder-laravel": "dev-feature/update-for-laravel-5-3@dev"
}

You may or may not need to add the repositories declaration:

"repositories": [
  {
    "type": "vcs",
    "url": "https://github.com/geocoder-php/GeocoderLaravel"
  }
],

Closing this, as this is really a duplicate of many other issues asking for the upgrade, and we're almost ready to release it.

If you do decide to use the feature branch, please let us know if you find any issues, that would be extremely helpful.

Thanks :)

@foziazahoor foziazahoor mentioned this issue Aug 3, 2017
Closed
@darkcast64 darkcast64 mentioned this issue Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bingalls @mikebronner