Skip to content

[Feature Request] Apartment numbers (subpremise) #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ellisio opened this issue Nov 8, 2016 · 6 comments
Closed

[Feature Request] Apartment numbers (subpremise) #52

ellisio opened this issue Nov 8, 2016 · 6 comments
Assignees
Milestone

Comments

@ellisio
Copy link

ellisio commented Nov 8, 2016

When parsing an address with an apartment number, you receive a "Subpremise" attribute. This attribute is typically mapped to an "Address Line 2".

For example: https://maps.googleapis.com/maps/api/geocode/json?address=2123%20W%20Mineral%20Ave%20Apt%2061,%20Littleton,%20CO%2080120

It would be nice to have this added as the subpremise on the Address object.

@mikebronner
Copy link
Member

Will take a look this week, thanks for reporting this! :) (Fair warning, this might be an issue with the underlying geodocer-php library.)

@mikebronner mikebronner self-assigned this Nov 9, 2016
@mikebronner mikebronner added this to the 1.0.0 milestone Nov 9, 2016
@mikebronner
Copy link
Member

Sorry its been taking so long to get a reply on this. Its on my radar, and will look at it as soon as possible. Happy Thanksgiving, everyone!

@mikebronner
Copy link
Member

This is actually an issue with GeocoderPHP itself. (I pend this as an issue there: geocoder-php/Geocoder#593.)

Looking at the code, the Address model does not have any address line 2 properties, so that would have to be added.

@mikebronner
Copy link
Member

@ellisio Quick update: the functionality will be added in the next major release of geocoded-php, and will make its way into this package then. :)

@ellisio
Copy link
Author

ellisio commented Jun 19, 2017

@mikebronner Awesome, thank you for the update! This'll be helpful with a feature we're currently R&Ding. 👍

@mikebronner
Copy link
Member

mikebronner commented Jun 19, 2017

Good to hear! Keep us updated on how it works. Best guess is that the release is about 3 weeks out, but you can download dev-master of this package and start using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants