Skip to content

Commit 65a7761

Browse files
xueeinsteinghostoy
authored andcommitted
add pre-release support
1 parent a8a6f43 commit 65a7761

File tree

2 files changed

+34
-18
lines changed

2 files changed

+34
-18
lines changed

tools/make-nw-headers.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import os
33
import tarfile
44
import sys
5+
import getnwisrelease
56
import getnwversion
67
import shutil
78
import distutils.core
@@ -25,6 +26,8 @@ def update_uvh(tmp_dir, header_files):
2526
tmp_dir = os.path.normpath(os.path.join(nw_root, 'tmp'))
2627

2728
nw_version = getnwversion.nw_version
29+
if getnwisrelease.release == 0:
30+
nw_version += getnwisrelease.postfix
2831

2932
#parse command line arguments
3033
'''

tools/package_binaries.py

Lines changed: 31 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
from subprocess import call
1414

15-
steps = ['nw', 'chromedriver', 'symbol', 'others']
15+
steps = ['nw', 'chromedriver', 'symbol', 'headers', 'others']
1616
################################
1717
# Parse command line args
1818
parser = argparse.ArgumentParser(description='Package nw binaries.')
@@ -33,8 +33,6 @@
3333
nw_ver = None # x.xx
3434
dist_dir = None # .../out/Release/dist
3535

36-
is_headers_ok = False # record whether nw-headers generated
37-
3836
step = args.step
3937
skip = args.skip
4038
binaries_location = args.path
@@ -201,26 +199,48 @@ def generate_target_symbols(platform_name, arch, version):
201199
exit(-1)
202200
return target
203201

204-
def generate_target_others(platform_name, arch, version):
202+
def generate_target_headers(platform_name, arch, version):
203+
# here, call make_nw_header tool to generate headers
204+
# then, move to binaries_location
205205
target = {}
206206
target['output'] = ''
207207
target['compress'] = None
208-
if platform_name == 'win':
209-
target['input'] = ['nw.exp', 'nw.lib']
210-
elif platform_name == 'linux' :
208+
if platform_name == 'osx':
211209
target['input'] = []
212210
# here , call make-nw-headers.py to generate nw headers
213-
# after generated, move to dist_dir
214211
make_nw_header = os.path.join(os.path.dirname(__file__), \
215212
'make-nw-headers.py')
216213
print make_nw_header
217214
res = call(['python', make_nw_header])
218215
if res == 0:
219-
global is_headers_ok
220-
is_headers_ok = True
221216
print 'nw-headers generated'
217+
nw_headers_name = 'nw-headers-v' + version + '.tar.gz'
218+
nw_headers_path = os.path.join(os.path.dirname(__file__), \
219+
os.pardir, 'tmp', nw_headers_name)
220+
if os.path.isfile(os.path.join(binaries_location, nw_headers_name)):
221+
os.remove(os.path.join(binaries_location, nw_headers_name))
222+
shutil.move(nw_headers_path, binaries_location)
223+
target['input'].append(nw_headers_name)
222224
else:
225+
#TODO, handle err
223226
print 'nw-headers generate failed'
227+
elif platform_name == 'win':
228+
target['input'] = []
229+
elif platform_name == 'linux':
230+
target['input'] = []
231+
else:
232+
print 'Unsupported platform: ' + platform_name
233+
exit(-1)
234+
return target
235+
236+
def generate_target_others(platform_name, arch, version):
237+
target = {}
238+
target['output'] = ''
239+
target['compress'] = None
240+
if platform_name == 'win':
241+
target['input'] = ['nw.exp', 'nw.lib']
242+
elif platform_name == 'linux' :
243+
target['input'] = []
224244
else:
225245
target['input'] = []
226246
return target
@@ -282,14 +302,6 @@ def make_packages(targets):
282302

283303
# now let's do it
284304
os.mkdir(dist_dir)
285-
# here check whether nw headers generated
286-
# if generated, mv to dist_dir
287-
if is_headers_ok:
288-
nw_headers_name = 'nw-headers-v' + nw_ver + '.tar.gz'
289-
nw_headers_path = os.path.join(os.path.dirname(__file__), \
290-
os.pardir, 'tmp', nw_headers_name)
291-
print 'Moving "' + nw_headers_name + '"'
292-
shutil.move(nw_headers_path, dist_dir)
293305
for t in targets:
294306
if len(t['input']) == 0:
295307
continue
@@ -327,6 +339,7 @@ def make_packages(targets):
327339
generators['nw'] = generate_target_nw
328340
generators['chromedriver'] = generate_target_chromedriver
329341
generators['symbol'] = generate_target_symbols
342+
generators['headers'] = generate_target_headers
330343
generators['others'] = generate_target_others
331344
################################
332345
# Process targets

0 commit comments

Comments
 (0)