Skip to content

Commit bc2db4f

Browse files
committed
Update dispatcher_host.cc
Was getting spammed with all these logs in the terminal: [24098:0402/164715:WARNING:dispatcher_host.cc(196)] Unknown object: 1 type:Window method:ShowDevTools arguments:[ "", false ] [24098:0402/164727:WARNING:dispatcher_host.cc(196)] Unknown object: 2 type:Window method:GetPosition arguments:[ ] [24098:0402/164727:WARNING:dispatcher_host.cc(196)] Unknown object: 2 type:Window method:GetPosition arguments:[ ] [24098:0402/164727:WARNING:dispatcher_host.cc(196)] Unknown object: 2 type:Window method:GetSize arguments:[ ] [24098:0402/164727:WARNING:dispatcher_host.cc(196)] Unknown object: 2 type:Window method:GetSize arguments:[ ] Fixed this by borrowing the same flow as DispatcherHost::OnCallObjectMethod (line 178).
1 parent 33221ac commit bc2db4f

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/api/dispatcher_host.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,12 +193,13 @@ void DispatcherHost::OnCallObjectMethodSync(
193193
<< " arguments:" << arguments;
194194

195195
Base* object = GetApiObject(object_id);
196-
LOG(WARNING) << "Unknown object: " << object_id
196+
if (object)
197+
object->CallSync(method, arguments, result);
198+
else
199+
DLOG(WARNING) << "Unknown object: " << object_id
197200
<< " type:" << type
198201
<< " method:" << method
199202
<< " arguments:" << arguments;
200-
if (object)
201-
object->CallSync(method, arguments, result);
202203
}
203204

204205
void DispatcherHost::OnCallStaticMethod(

0 commit comments

Comments
 (0)