fix windows compilation for nwsnapshot

rogerwang · rogerwang · commit df852184ccea · 2015-02-26T20:12:04.000+08:00
diff --git a/nw.gypi b/nw.gypi
@@ -579,7 +579,7 @@
               },
             },
           },
-          'msvs_disabled_warnings': [ 4267, 4800, 4819, 4189 ],
+          'msvs_disabled_warnings': [ 4267, 4800, 4819, 4189, 4245, 4324 ],
         }],  # OS=="win"
       ],
     },
diff --git a/src/api/dispatcher.h b/src/api/dispatcher.h
@@ -25,6 +25,7 @@
 #include "content/public/renderer/render_view_observer.h"
 #include "third_party/WebKit/public/web/WebNavigationPolicy.h"
 #include <v8.h>
+#include <string>
 
 namespace base {
 class ListValue;
diff --git a/src/api/window_bindings.cc b/src/api/window_bindings.cc
@@ -159,7 +159,11 @@ WindowBindings::CallObjectMethod(const v8::FunctionCallbackInfo<v8::Value>& args
     args.GetReturnValue().Set(result);
     return;
   } else if (method == "EvaluateNWBin") {
+#if defined(OS_WIN)
+    base::FilePath path((WCHAR*)*v8::String::Value(args[3]));
+#else
     base::FilePath path(*v8::String::Utf8Value(args[3]));
+#endif
     base::File file(path, base::File::FLAG_OPEN | base::File::FLAG_READ);
     if (file.IsValid()) {
       int64 length = file.GetLength();
diff --git a/src/nw_notification_manager_win.cc b/src/nw_notification_manager_win.cc
@@ -34,6 +34,8 @@
 
 #include "content/nw/src/nw_notification_manager_win.h"
 
+#include <shellapi.h>
+
 namespace nw {
 class TrayObserver : public StatusIconObserver {
 public:
diff --git a/src/renderer/nw_render_view_observer.h b/src/renderer/nw_render_view_observer.h
@@ -23,6 +23,8 @@
 
 #include "content/public/renderer/render_view_observer.h"
 
+#include <string>
+
 class SkBitmap;
 
 namespace content {
