Skip to content

Commit ee296e4

Browse files
committed
[Notification][linux] change render_view to render_frame
1 parent a40be62 commit ee296e4

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

src/nw_notification_manager_linux.cc

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,12 @@ void NotificationManagerLinux::onClose(NotifyNotification *notif)
7272

7373
bool NotificationManagerLinux::AddDesktopNotification(const content::ShowDesktopNotificationHostMsgParams& params,
7474
const int render_process_id,
75-
const int render_view_id,
75+
const int render_frame_id,
7676
const int notification_id,
7777
const bool worker,
7878
const std::vector<SkBitmap>* bitmaps) {
7979

80-
content::RenderViewHost* host = content::RenderFrameHost::FromID(render_process_id, render_view_id)->GetRenderViewHost();
80+
content::RenderViewHost* host = content::RenderFrameHost::FromID(render_process_id, render_frame_id)->GetRenderViewHost();
8181
if (host == NULL)
8282
return false;
8383

@@ -88,7 +88,7 @@ bool NotificationManagerLinux::AddDesktopNotification(const content::ShowDesktop
8888
DesktopNotificationParams desktop_notification_params;
8989
desktop_notification_params.params_ = params;
9090
desktop_notification_params.render_process_id_ = render_process_id;
91-
desktop_notification_params.render_view_id_ = render_view_id;
91+
desktop_notification_params.render_frame_id_ = render_frame_id;
9292

9393
// download the icon image first
9494
content::WebContents::ImageDownloadCallback imageDownloadCallback = base::Bind(&NotificationManager::ImageDownloadCallback);
@@ -118,7 +118,7 @@ bool NotificationManagerLinux::AddDesktopNotification(const content::ShowDesktop
118118
NotificationData data;
119119
data.mNotification = notif;
120120
data.mRenderProcessId = render_process_id;
121-
data.mRenderViewId = render_view_id;
121+
data.mRenderViewId = render_frame_id;
122122
mNotificationIDmap[notification_id] = data;
123123
}
124124
else {
@@ -133,7 +133,7 @@ bool NotificationManagerLinux::AddDesktopNotification(const content::ShowDesktop
133133
g_object_ref(G_OBJECT(notif));
134134
onClose(notif);
135135
data.mRenderProcessId = render_process_id;
136-
data.mRenderViewId = render_view_id;
136+
data.mRenderViewId = render_frame_id;
137137
mNotificationIDmap[notification_id] = data;
138138
}
139139
}
@@ -146,16 +146,16 @@ bool NotificationManagerLinux::AddDesktopNotification(const content::ShowDesktop
146146

147147
GError* error = NULL;
148148
if (notify_notification_show (notif, &error)) {
149-
DesktopNotificationPostDisplay(render_process_id, render_view_id, notification_id);
149+
DesktopNotificationPostDisplay(render_process_id, render_frame_id, notification_id);
150150
}
151151
else {
152152
base::string16 errorMsg = base::UTF8ToUTF16(error->message);
153-
DesktopNotificationPostError(render_process_id, render_view_id, notification_id, errorMsg);
153+
DesktopNotificationPostError(render_process_id, render_frame_id, notification_id, errorMsg);
154154
}
155155
return error==NULL;
156156
}
157157

158-
bool NotificationManagerLinux::CancelDesktopNotification(int render_process_id, int render_view_id, int notification_id) {
158+
bool NotificationManagerLinux::CancelDesktopNotification(int render_process_id, int render_frame_id, int notification_id) {
159159
NotificationMap::const_iterator i = getNotification(notification_id);
160160
if (i!=mNotificationIDmap.end()) {
161161
return notify_notification_close(i->second.mNotification, NULL);
@@ -165,10 +165,10 @@ bool NotificationManagerLinux::CancelDesktopNotification(int render_process_id,
165165

166166
bool NotificationManagerLinux::AddDesktopNotification(const content::ShowDesktopNotificationHostMsgParams& params,
167167
const int render_process_id,
168-
const int render_view_id,
168+
const int render_frame_id,
169169
const int notification_id,
170170
const bool worker) {
171-
return AddDesktopNotification(params, render_process_id, render_view_id, notification_id, worker, NULL);
171+
return AddDesktopNotification(params, render_process_id, render_frame_id, notification_id, worker, NULL);
172172
}
173173

174174
} // namespace nw

src/nw_notification_manager_linux.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class NotificationManagerLinux : public NotificationManager {
4343
// internal function for AddDesktopNotification
4444
virtual bool AddDesktopNotification(const content::ShowDesktopNotificationHostMsgParams& params,
4545
const int render_process_id,
46-
const int render_view_id,
46+
const int render_frame_id,
4747
const int notification_id,
4848
const bool worker,
4949
const std::vector<SkBitmap>* bitmaps) OVERRIDE;
@@ -53,10 +53,10 @@ class NotificationManagerLinux : public NotificationManager {
5353
virtual ~NotificationManagerLinux();
5454
virtual bool AddDesktopNotification(const content::ShowDesktopNotificationHostMsgParams& params,
5555
const int render_process_id,
56-
const int render_view_id,
56+
const int render_frame_id,
5757
const int notification_id,
5858
const bool worker) OVERRIDE;
59-
virtual bool CancelDesktopNotification(int render_process_id, int render_view_id, int notification_id) OVERRIDE;
59+
virtual bool CancelDesktopNotification(int render_process_id, int render_frame_id, int notification_id) OVERRIDE;
6060
};
6161

6262
} // namespace nw

0 commit comments

Comments
 (0)