Skip to content

Commit f9b6f3f

Browse files
committed
[nw10] rebase fix: icudct.dat and force linking all objs in node
1 parent 2c5c352 commit f9b6f3f

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

nw.gypi

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -832,6 +832,7 @@
832832
'mac_bundle': 1,
833833
'mac_bundle_resources': [
834834
'src/mac/English.lproj/HttpAuth.xib',
835+
'<(PRODUCT_DIR)/icudtl.dat',
835836
'<(PRODUCT_DIR)/nw.pak',
836837
'<(PRODUCT_DIR)/locale/en-US.pak',
837838
'<(PRODUCT_DIR)/locale/am.pak',
@@ -897,6 +898,7 @@
897898
'src/shell_content_main.cc',
898899
'src/shell_content_main.h',
899900
],
901+
'xcode_settings': { 'OTHER_LDFLAGS': [ '-Wl,-force_load,libnode.a' ], },
900902
'copies': [
901903
{
902904
# Copy FFmpeg binaries for audio/video support.

src/shell_main_delegate.cc

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,15 @@ bool ShellMainDelegate::BasicStartupComplete(int* exit_code) {
129129
logging::LogEventProvider::Initialize(kContentShellProviderName);
130130
#endif
131131

132+
#if defined(OS_MACOSX)
133+
// Needs to happen before InitializeResourceBundle() and before
134+
// WebKitTestPlatformInitialize() are called.
135+
OverrideFrameworkBundlePath();
136+
OverrideChildProcessPath();
137+
// FIXME: EnsureCorrectResolutionSettings();
138+
l10n_util::OverrideLocaleWithUserDefault();
139+
#endif // OS_MACOSX
140+
132141
InitLogging();
133142
// FIXME: net::CookieMonster::EnableFileScheme();
134143

@@ -144,11 +153,6 @@ void ShellMainDelegate::PreSandboxStartup() {
144153
pref_locale = command_line->GetSwitchValueASCII(switches::kLang);
145154
}
146155

147-
#if defined(OS_MACOSX)
148-
OverrideFrameworkBundlePath();
149-
OverrideChildProcessPath();
150-
l10n_util::OverrideLocaleWithUserDefault();
151-
#endif // OS_MACOSX
152156
InitializeResourceBundle(pref_locale);
153157

154158
std::string process_type =

0 commit comments

Comments
 (0)