BUG18814880: Fix stopping mysqld running unit tests on Windows

Geert Vanderkelen · Geert Vanderkelen · commit 59fe76a9e020 · 2014-06-23T09:56:02.000+02:00
The error "Procedure probably called with not enough arguments"
occurs when calling the winkernel.WaitForSingleObject() without
the timeout argument. We fix this by refactoring process_terminate()
function in the test.mysqld module and not use WaitForSingleObject
any longer.
diff --git a/tests/mysqld.py b/tests/mysqld.py
@@ -109,14 +109,16 @@ def process_running(pid):
 def process_terminate(pid):
     """Terminates a process
 
-    This function terminates a running process, sending a SIGKILL on
-    Posix systems and using ctypes.windll on Windows.
+    This function terminates a running process using it's pid (process
+    ID), sending a SIGKILL on Posix systems and using ctypes.windll
+    on Windows.
+
+    Raises MySQLServerError on errors.
     """
     if os.name == 'nt':
         winkernel = ctypes.windll.kernel32
-        process = winkernel.OpenProcess(1, 0, pid)
-        winkernel.TerminateProcess(process, -1)
-        winkernel.WaitForSingleObject(process)
+        process = winkernel.OpenProcess(0x0001, 0, pid)  # PROCESS_TERMINATE
+        winkernel.TerminateProcess(process, 1)
         winkernel.CloseHandle(process)
     else:
         os.kill(pid, signal.SIGTERM)
