BUG18956789: Fix Django TimeField 00:00:00 converting to MySQL NULL

peeyushgupta · peeyushgupta · commit f9997a56158e · 2014-06-26T12:02:07.000+05:30
We fix saving Django's TimeField values so that 00:00:00 is correctly
converted instead of saving as NULL. Python considered a time 00:00:00
as False, which gave problems when validating.
diff --git a/lib/mysql/connector/django/base.py b/lib/mysql/connector/django/base.py
@@ -385,7 +385,7 @@ def validate_autopk_value(self, value):
         return value
 
     def value_to_db_datetime(self, value):
-        if not value:
+        if value is None:
             return None
         # MySQL doesn't support tz-aware times
         if timezone.is_aware(value):
@@ -405,7 +405,7 @@ def value_to_db_datetime(self, value):
         return self.connection.connection.converter._datetime_to_mysql(value)
 
     def value_to_db_time(self, value):
-        if not value:
+        if value is None:
             return None
 
         # MySQL doesn't support tz-aware times
diff --git a/tests/test_django.py b/tests/test_django.py
@@ -207,3 +207,34 @@ def test__init__(self):
         self.assertEqual(exp, self.cnx.ops.value_to_db_time(value))
 
 
+class DjangoDatabaseOperations(tests.MySQLConnectorTests):
+
+    """Test the Django base.DatabaseOperations class"""
+
+    def setUp(self):
+        dbconfig = tests.get_mysql_config()
+        self.conn = mysql.connector.connect(**dbconfig)
+        self.cnx = DatabaseWrapper(settings.DATABASES['default'])
+        self.dbo = DatabaseOperations(self.cnx)
+
+    def test_value_to_db_time(self):
+        self.assertEqual(None, self.dbo.value_to_db_time(None))
+
+        value = datetime.time(0, 0, 0)
+        exp = self.conn.converter._time_to_mysql(value)
+        self.assertEqual(exp, self.dbo.value_to_db_time(value))
+
+        value = datetime.time(2, 5, 7)
+        exp = self.conn.converter._time_to_mysql(value)
+        self.assertEqual(exp, self.dbo.value_to_db_time(value))
+
+    def value_to_db_datetime(self, value):
+        self.assertEqual(None, self.dbo.value_to_db_datetime(None))
+
+        value = datetime.datetime(1, 1, 1)
+        exp = self.conn.converter._datetime_to_mysql(value)
+        self.assertEqual(exp, self.dbo.value_to_db_datetime(value))
+
+        value = datetime.time(2,5,7, 10, 10)
+        exp = self.conn.converter._datetime_to_mysql(value)
+        self.assertEqual(exp, self.dbo.value_to_db_datetime(value))
