Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getsentry/sentry-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: getsentry/sentry-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: rominf-tracing-fix-logic-in_app
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Sep 5, 2024

  1. ref(tracing): Move should_be_included logic into function

    The change is required for unit testing the logic.
    rominf committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e3bb1c0 View commit details
    Browse the repository at this point in the history
  2. fix(tracing): Fix add_query_source with modules outside of project …

    …root
    
    Fix: #3312
    
    Previously, when packages added in `in_app_include` were installed
    to a location outside of the project root directory, span from
    those packages were not extended with OTel compatible source code
    information. Cases include running Python from virtualenv created
    outside of the project root directory or Python packages installed into
    the system using package managers. This resulted in an inconsistency:
    spans from the same project would be different, depending on the
    deployment method.
    
    In this change, the logic was slightly changed to avoid these
    discrepancies and conform to the requirements, described in the PR with
    better setting of in-app in stack frames:
    #1894 (comment).
    rominf committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c6ce9c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    b7c382f View commit details
    Browse the repository at this point in the history
Loading