Skip to content

Better Test structure #4480

@antonpirker

Description

@antonpirker

Right now it is hard to get tests right and there is a lot of magic in conftest.py (and probably other places) and the isolation of tests is alo lacking (resulting in use of pytest.mark.forked usage)

Idea of a better test structure:

def test_something(sentry_init):
    sentry_client = sentry_init(dsn, ...)

    # do something

    sentry_client.transport.envelopes
    # -> array of envelopes

    sentry_client.transport.events
    # -> array of captured events

There is a custom transport on the client that collects data on class internal arrays that can be accessed via properties.

Those arrays should be cleaned after each test run. Should also work in async, and gevent, and eventlet code.

Basically just have one fixture for testing most of the stuff

Also tests should never alter the global state so they are self contained and can run in parallel without pytest markers.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions