Skip to content

Fix parameter order issue for hybrid memory initialization #14725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

dinerburger
Copy link
Contributor

Make sure to read the contributing guidelines before submitting a PR

Fixes #14724 ; simply reordering the parameters resolves the issue.

@MaggotHATE
Copy link
Contributor

Can confirm that this fixed the issue, thank you!

Copy link
Collaborator

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@dinerburger
Copy link
Contributor Author

Happy to help, thanks for all your hard work on the project!

@CISC CISC merged commit 496957e into ggml-org:master Jul 16, 2025
45 of 48 checks passed
@dinerburger dinerburger deleted the fix-hybrid branch July 16, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misc. bug: Hybrid models failing to load with assert GGML_ASSERT(kv_size % n_pad == 0)
3 participants