Replies: 2 comments 6 replies
-
|
How would you expect this to be surfaced in the API? |
Beta Was this translation helpful? Give feedback.
-
Return an object that has a |
Beta Was this translation helpful? Give feedback.
-
it = gh.getiter(...)
count = it.total_count
async for item in it:
... |
Beta Was this translation helpful? Give feedback.
-
|
It's an interesting idea. I'm not totally opposed to it, but I have also never had a need to know the total count either. |
Beta Was this translation helpful? Give feedback.
-
|
I think this is an interesting approach. Currently I have to get the |
Beta Was this translation helpful? Give feedback.
-
|
i would be very plus one to this, just trying to figure out how to migrate some code from without capturing the data in the request as they do, its looking messy pygithub count handling: |
Beta Was this translation helpful? Give feedback.
-
|
i have an implementation here: i would be happy to fold this upstream, but i guess i need to figure out tests etc |
Beta Was this translation helpful? Give feedback.
-
If I'm calling
getiteron a paginated API, it only provides a lazy iterator over the results. However, I need to know the total number of results in advance, and GitHub provides it in the response -total_count, just that the response is completely locked away from the user, unless they call_make_requestdirectly like sohttps://github.com/brettcannon/gidgethub/blob/3b8941a0ccdad007db09dd601963ce989d64074f/gidgethub/abc.py#L148-L150
(
getitemalso discards that info).Example of this elsewhere: https://pygithub.readthedocs.io/en/latest/utilities.html?highlight=totalCount#github.PaginatedList.PaginatedList
Beta Was this translation helpful? Give feedback.
All reactions