perf: 移除不必要的 api

painld6 · painld6 · commit 3f4ef1ab3e07 · 2021-08-18T10:40:19.000+08:00
diff --git a/library/src/main/java/com/opensource/svgaplayer/utils/log/DefaultLogCat.kt b/library/src/main/java/com/opensource/svgaplayer/utils/log/DefaultLogCat.kt
@@ -22,15 +22,7 @@ class DefaultLogCat : ILogger {
         Log.w(tag, msg)
     }
 
-    override fun error(tag: String, msg: String) {
-        Log.e(tag, msg)
-    }
-
-    override fun error(tag: String, error: Throwable) {
-        Log.e(tag, "", error)
-    }
-
-    override fun error(tag: String, msg: String, error: Throwable) {
+    override fun error(tag: String, msg: String?, error: Throwable?) {
         Log.e(tag, msg, error)
     }
 }
diff --git a/library/src/main/java/com/opensource/svgaplayer/utils/log/ILogger.kt b/library/src/main/java/com/opensource/svgaplayer/utils/log/ILogger.kt
@@ -8,7 +8,5 @@ interface ILogger {
     fun info(tag: String, msg: String)
     fun debug(tag: String, msg: String)
     fun warn(tag: String, msg: String)
-    fun error(tag: String, msg: String)
-    fun error(tag: String, error: Throwable)
-    fun error(tag: String, msg: String, error: Throwable)
+    fun error(tag: String, msg: String?, error: Throwable?)
 }
diff --git a/library/src/main/java/com/opensource/svgaplayer/utils/log/LogUtils.kt b/library/src/main/java/com/opensource/svgaplayer/utils/log/LogUtils.kt
@@ -38,20 +38,20 @@ internal object LogUtils {
         if (!SVGALogger.isLogEnabled()) {
             return
         }
-        SVGALogger.getSVGALogger()?.error(tag, msg)
+        SVGALogger.getSVGALogger()?.error(tag, msg, null)
     }
 
-    fun error(tag: String = TAG, msg: String, error: Throwable) {
+    fun error(tag: String, error: Throwable) {
         if (!SVGALogger.isLogEnabled()) {
             return
         }
-        SVGALogger.getSVGALogger()?.error(tag, msg, error)
+        SVGALogger.getSVGALogger()?.error(tag, error.message, error)
     }
 
-    fun error(tag: String, error: Throwable) {
+    fun error(tag: String = TAG, msg: String, error: Throwable) {
         if (!SVGALogger.isLogEnabled()) {
             return
         }
-        SVGALogger.getSVGALogger()?.error(tag, error)
+        SVGALogger.getSVGALogger()?.error(tag, msg, error)
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -22,15 +22,7 @@ class DefaultLogCat : ILogger {`
`22`	`22`	`Log.w(tag, msg)`
`23`	`23`	`}`
`24`	`24`
`25`		`- override fun error(tag: String, msg: String) {`
`26`		`- Log.e(tag, msg)`
`27`		`- }`
`28`		`-`
`29`		`- override fun error(tag: String, error: Throwable) {`
`30`		`- Log.e(tag, "", error)`
`31`		`- }`
`32`		`-`
`33`		`- override fun error(tag: String, msg: String, error: Throwable) {`
	`25`	`+ override fun error(tag: String, msg: String?, error: Throwable?) {`
`34`	`26`	`Log.e(tag, msg, error)`
`35`	`27`	`}`
`36`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,5 @@ interface ILogger {`
`8`	`8`	`fun info(tag: String, msg: String)`
`9`	`9`	`fun debug(tag: String, msg: String)`
`10`	`10`	`fun warn(tag: String, msg: String)`
`11`		`- fun error(tag: String, msg: String)`
`12`		`- fun error(tag: String, error: Throwable)`
`13`		`- fun error(tag: String, msg: String, error: Throwable)`
	`11`	`+ fun error(tag: String, msg: String?, error: Throwable?)`
`14`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,20 +38,20 @@ internal object LogUtils {`
`38`	`38`	`if (!SVGALogger.isLogEnabled()) {`
`39`	`39`	`return`
`40`	`40`	`}`
`41`		`- SVGALogger.getSVGALogger()?.error(tag, msg)`
	`41`	`+ SVGALogger.getSVGALogger()?.error(tag, msg, null)`
`42`	`42`	`}`
`43`	`43`
`44`		`- fun error(tag: String = TAG, msg: String, error: Throwable) {`
	`44`	`+ fun error(tag: String, error: Throwable) {`
`45`	`45`	`if (!SVGALogger.isLogEnabled()) {`
`46`	`46`	`return`
`47`	`47`	`}`
`48`		`- SVGALogger.getSVGALogger()?.error(tag, msg, error)`
	`48`	`+ SVGALogger.getSVGALogger()?.error(tag, error.message, error)`
`49`	`49`	`}`
`50`	`50`
`51`		`- fun error(tag: String, error: Throwable) {`
	`51`	`+ fun error(tag: String = TAG, msg: String, error: Throwable) {`
`52`	`52`	`if (!SVGALogger.isLogEnabled()) {`
`53`	`53`	`return`
`54`	`54`	`}`
`55`		`- SVGALogger.getSVGALogger()?.error(tag, error)`
	`55`	`+ SVGALogger.getSVGALogger()?.error(tag, msg, error)`
`56`	`56`	`}`
`57`	`57`	`}`