This repository was archived by the owner on Jun 21, 2023. It is now read-only.
It's nearly impossible to tell where a file has moved from and to #1961
Labels
Comments
|
@meaghanlewis could you see if you can repro this? It's a bit of a nasty one. 😭 |
|
@jcansdale I can reproduce this and see exactly what you mean about not being able to tell a file was moved and not being able to comment on the moved file. I don't see any other editors handle this situation. I think it makes sense yo try to do what dotcom does here like you suggest and:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Version
What happened
Steps to Reproduce
Expected behavior: [What you expect to happen]
Tooltip of diff tab shows source and destination of moved file.
Actual behavior: [What actually happens]
Tooltip shows destination path as both source and destination.
File appears as an added file in diff (all green on RHS).
Screenshot or GIF:
If I try to comment, I get position is invalid:
Here is the same file on dotcom for comparison:
Proposed Solution
Having just the destination on the tree view node isn't useful without a source to compare it with. I'd suggest simply showing
[moved]on the node to avoid horizontal scrolling issues for minimal gain. Having the a source and destination as the tooltip would be very useful.The text was updated successfully, but these errors were encountered: