Skip to content

[accessibility-alt-text-bot] Support for Discussions #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
khiga8 opened this issue May 10, 2023 · 2 comments · Fixed by #17
Closed
3 tasks done

[accessibility-alt-text-bot] Support for Discussions #11

khiga8 opened this issue May 10, 2023 · 2 comments · Fixed by #17
Assignees
@khiga8

Comments

@khiga8
Copy link
Contributor

khiga8 commented May 10, 2023 •
edited
Loading

Currently this action has support for Issues and Pull Requests. Let's add support for Discussions!

  • Support for discussion body
  • Support for discussion comment
  • Cut new release
@khiga8 khiga8 mentioned this issue May 10, 2023
Merged
@kendallgassner
Copy link
Collaborator

kendallgassner commented May 10, 2023 •
edited
Loading

I actually think we just need to use the discussions dispatch:

discussion:
    types: [created, edited]
discussion_comment:
    types: [created, edited]

And possibly add event.discussion as well

 if: ${{ github.event.issue || github.event.pull_request }}

@kendallgassner
Copy link
Collaborator

Ah, I see we will need some additional logic to gather the right params.

Reference:
action.yml line 13

@khiga8 khiga8 self-assigned this May 19, 2023
@khiga8 khiga8 mentioned this issue May 19, 2023
Merged
@khiga8 khiga8 mentioned this issue May 31, 2023
Merged
@inkblotty inkblotty changed the title Support for Discussions [accessibility-alt-text-bot] Support for Discussions May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khiga8 khiga8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for discussion comment github/accessibility-alt-text-bot
2 participants
@kendallgassner @khiga8