Skip to content

Flag images with no alt text at all #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mr0grog opened this issue Jun 21, 2023 · 0 comments · Fixed by #26
Closed

Flag images with no alt text at all #23

Mr0grog opened this issue Jun 21, 2023 · 0 comments · Fixed by #26
Assignees

Comments

@Mr0grog
Copy link

Mr0grog commented Jun 21, 2023

I really like the idea behind this action! However, the first few images I tried to test it with didn’t get flagged like I expected.

In the first instance, I happened to drag an image into the text area that had a filename that wasn’t “Screenshot ” (it was “edit-link.png”). I’m not sure if there’s a good way to identify stuff like this (maybe check alt-text with no spaces against a dictionary? tough to handle lots of languages, though…).

In the second instance, I tried just deleting the alt text entirely (all the variations of <img alt="" ...>, <img ...> (no alt attribute at all), and ![](<image url>)). These seem more obviously straightforward to identify, and it would be nice if they were caught by this action.


As a side note, I thought I’d configured something wrong because of the above. The first thing I did was look at the action’s logging output, and it would have been a little bit helpful to have the two outputs (whether an image was flagged and the type of thing being checked) labeled so I knew what they were:

echo $flag
echo $type

(e.g. echo "Detected bad alt text: ${flag}" would have been helpful.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants