Install chrome in codespaces via Dockerfile rather than use node-chromium package #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrome is now installed in codespace in the Dockerfile
15b0803 to
ec544c0
Compare
manuelpuyol
approved these changes
May 17, 2022
KyFaSt
added a commit
to github/details-menu-element
that referenced
this pull request
Apr 11, 2023
…mium package * cribbed from github/auto-complete-element#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's flakiness with the node-chromium package installation process that was causing our Node CI action to be flaky. This PR installs chrome in out
.devcontainer/Dockerfilemaking chrome globally available in codespaces, and thus elevating the need fornode-chromium.