C#: Add extraction error diagnostic query

tamasvajk · tamasvajk · commit 5149ffdd16f4 · 2021-04-22T09:13:06.000+02:00
diff --git a/csharp/ql/src/Diagnostics/DiagnosticExtractionErrors.ql b/csharp/ql/src/Diagnostics/DiagnosticExtractionErrors.ql
@@ -0,0 +1,18 @@
+/**
+ * @name Extraction errors
+ * @description List all errors reported by the extractor. The returned issues are
+ *              limited to those files where there are no compilation errors. This
+ *              indicates a bug or limitation in the extractor, and could lead to
+ *              inaccurate results.
+ * @kind diagnostic
+ * @id cs/diagnostics/extraction-errors
+ */
+
+import csharp
+import semmle.code.csharp.commons.Diagnostics
+
+from ExtractorError error
+where not exists(CompilerError ce | ce.getLocation().getFile() = error.getLocation().getFile())
+select error,
+  "Unexpected " + error.getOrigin() + " error: " + error.getText() + " in " +
+    error.getLocation().getFile(), 3
diff --git a/csharp/ql/test/library-tests/diagnostics/DiagnosticExtractorErrors.expected b/csharp/ql/test/library-tests/diagnostics/DiagnosticExtractorErrors.expected
diff --git a/csharp/ql/test/library-tests/diagnostics/DiagnosticExtractorErrors.qlref b/csharp/ql/test/library-tests/diagnostics/DiagnosticExtractorErrors.qlref
@@ -0,0 +1 @@
+Diagnostics/DiagnosticExtractionErrors.ql
diff --git a/csharp/ql/test/library-tests/diagnostics/Program.cs b/csharp/ql/test/library-tests/diagnostics/Program.cs
@@ -0,0 +1,17 @@
+// semmle-extractor-options: --standalone
+
+using System;
+
+class Class
+{
+    static void Main(string[] args)
+    {
+        int z = GetParamLength(__arglist(1, 2));
+    }
+
+    public static int GetParamLength(__arglist)
+    {
+        ArgIterator iterator = new ArgIterator(__arglist);
+        return iterator.GetRemainingCount();
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Diagnostics/DiagnosticExtractionErrors.ql`