Remove redundant getUnderlyingType()

owen-mc · owen-mc · commit 8552774bb9ad · 2024-11-26T12:27:30.000Z
If `T` is the type of an embedded field, it is invalid for `T` to be a
named type defined to be a pointer type (`type T *S`). It is also
invalid for `T` to be a type parameter. So this `getUnderlyingType()` is
redundant.
diff --git a/go/ql/lib/semmle/go/Types.qll b/go/ql/lib/semmle/go/Types.qll
@@ -498,7 +498,7 @@ class StructType extends @structtype, CompositeType {
     this.hasFieldCand(_, embeddedParent, depth - 1, true) and
     // embeddedParent's type has the result field
     exists(StructType embeddedType, Type fieldType |
-      fieldType = embeddedParent.getType().getUnderlyingType() and
+      fieldType = embeddedParent.getType() and
       pragma[only_bind_into](embeddedType) =
         [fieldType, fieldType.(PointerType).getBaseType().getUnderlyingType()]
     |

Original file line number	Diff line number	Diff line change
`@@ -498,7 +498,7 @@ class StructType extends @structtype, CompositeType {`
`498`	`498`	`this.hasFieldCand(_, embeddedParent, depth - 1, true) and`
`499`	`499`	`// embeddedParent's type has the result field`
`500`	`500`	`exists(StructType embeddedType, Type fieldType \|`
`501`		`- fieldType = embeddedParent.getType().getUnderlyingType() and`
	`501`	`+ fieldType = embeddedParent.getType() and`
`502`	`502`	`pragma[only_bind_into](embeddedType) =`
`503`	`503`	`[fieldType, fieldType.(PointerType).getBaseType().getUnderlyingType()]`
`504`	`504`	`\|`