JS: Remove reference to deprecated step relation that's empty anyway

asgerf · asgerf · commit 947b785d47b0 · 2024-12-16T15:35:53.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataCustomizations.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/ExternalAPIUsedWithUntrustedDataCustomizations.qll
@@ -252,7 +252,6 @@ module ExternalApiUsedWithUntrustedData {
       |
         TaintTracking::sharedTaintStep(arg, _) or
         DataFlow::SharedFlowStep::step(arg, _) or
-        DataFlow::SharedFlowStep::step(arg, _, _, _) or
         DataFlow::SharedFlowStep::loadStep(arg, _, _) or
         DataFlow::SharedFlowStep::storeStep(arg, _, _) or
         DataFlow::SharedFlowStep::loadStoreStep(arg, _, _)
diff --git a/javascript/ql/src/meta/analysis-quality/TaintSteps.ql b/javascript/ql/src/meta/analysis-quality/TaintSteps.ql
@@ -17,8 +17,6 @@ predicate relevantStep(DataFlow::Node pred, DataFlow::Node succ) {
     or
     DataFlow::SharedFlowStep::step(pred, succ)
     or
-    DataFlow::SharedFlowStep::step(pred, succ, _, _)
-    or
     DataFlow::SharedFlowStep::loadStep(pred, succ, _)
     or
     DataFlow::SharedFlowStep::storeStep(pred, succ, _)
diff --git a/javascript/ql/src/meta/analysis-quality/UnmodelledSteps.ql b/javascript/ql/src/meta/analysis-quality/UnmodelledSteps.ql
@@ -24,8 +24,6 @@ predicate unmodeled(API::Node callee, API::CallNode call, DataFlow::Node pred, D
     or
     DataFlow::SharedFlowStep::step(_, succ)
     or
-    DataFlow::SharedFlowStep::step(_, succ, _, _)
-    or
     DataFlow::SharedFlowStep::loadStep(_, succ, _)
     or
     DataFlow::SharedFlowStep::storeStep(_, succ, _)

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,6 @@ module ExternalApiUsedWithUntrustedData {`
`252`	`252`	`\|`
`253`	`253`	`TaintTracking::sharedTaintStep(arg, _) or`
`254`	`254`	`DataFlow::SharedFlowStep::step(arg, _) or`
`255`		`- DataFlow::SharedFlowStep::step(arg, _, _, _) or`
`256`	`255`	`DataFlow::SharedFlowStep::loadStep(arg, _, _) or`
`257`	`256`	`DataFlow::SharedFlowStep::storeStep(arg, _, _) or`
`258`	`257`	`DataFlow::SharedFlowStep::loadStoreStep(arg, _, _)`