Python: Add failing tests for undefined variable as value and nested 'from import *'.

markshannon · markshannon · commit c4a79c2ea147 · 2019-06-24T12:18:48.000+01:00
diff --git a/python/ql/test/library-tests/PointsTo/import_star/Values.expected b/python/ql/test/library-tests/PointsTo/import_star/Values.expected
@@ -0,0 +1,4 @@
+| nested/__init__.py:1:6:1:12 | ControlFlowNode for ImportExpr | import | nested/nested.py:0:0:0:0 | Module nested.nested |
+| nested/nested.py:1:1:1:13 | ControlFlowNode for FunctionExpr | import | nested/nested.py:1:1:1:13 | Function nested |
+| test.py:1:6:1:11 | ControlFlowNode for ImportExpr | import | file://:0:0:0:0 | Package nested |
+| test.py:2:1:2:6 | ControlFlowNode for nested | import | nested/nested.py:1:1:1:13 | Function nested |
diff --git a/python/ql/test/library-tests/PointsTo/import_star/Values.ql b/python/ql/test/library-tests/PointsTo/import_star/Values.ql
@@ -0,0 +1,7 @@
+
+import python
+
+from ControlFlowNode f, Context ctx, Value v, ControlFlowNode origin
+where
+  f.pointsTo(ctx, v, origin)
+select f, ctx, v
diff --git a/python/ql/test/library-tests/PointsTo/import_star/nested/__init__.py b/python/ql/test/library-tests/PointsTo/import_star/nested/__init__.py
@@ -0,0 +1 @@
+from .nested import *
diff --git a/python/ql/test/library-tests/PointsTo/import_star/nested/nested.py b/python/ql/test/library-tests/PointsTo/import_star/nested/nested.py
@@ -0,0 +1,2 @@
+def nested():
+    pass
diff --git a/python/ql/test/library-tests/PointsTo/import_star/test.py b/python/ql/test/library-tests/PointsTo/import_star/test.py
@@ -0,0 +1,2 @@
+from nested import *
+nested
diff --git a/python/ql/test/library-tests/PointsTo/new/Sanity.ql b/python/ql/test/library-tests/PointsTo/new/Sanity.ql
@@ -109,7 +109,17 @@ predicate ssa_sanity(string clsname, string problem, string what) {
     )
 }
 
+predicate undefined_sanity(string clsname, string problem, string what) {
+    /* Variables may be undefined, but values cannot be */
+    exists(ControlFlowNode f |
+        PointsToInternal::pointsTo(f, _, ObjectInternal::undefined(), _) and
+        clsname = f.getAQlClass() and not clsname = "AnyNode" and
+        problem = " points-to an undefined variable" and
+        what = f.toString()
+    )
+}
+
 from string clsname, string problem, string what
-where ssa_sanity(clsname, problem, what)
+where ssa_sanity(clsname, problem, what) or undefined_sanity(clsname, problem, what)
 select clsname, what, problem
 
