Skip to content

Commit d19188d

Browse files
committed
Address review comment
1 parent 0bf2bfa commit d19188d

File tree

8 files changed

+12
-25
lines changed

8 files changed

+12
-25
lines changed

rust/extractor/src/crate_graph.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ pub fn extract_crate_graph(trap_provider: &trap::TrapFileProvider, db: &RootData
9494
.flat_map(|x| crate_id_map.get(&x.crate_id).map(|y| (&x.name, y)))
9595
.map(|(name, (module, hash))| generated::NamedCrate {
9696
id: trap::TrapId::Star,
97-
name: name.to_string().into(),
97+
name: name.to_string(),
9898
crate_: trap.label(format!("{}:{hash}", module.display()).into()),
9999
})
100100
.collect();

rust/extractor/src/generated/.generated.list

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/extractor/src/generated/top.rs

+2-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/ql/.generated.list

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/ql/lib/codeql/rust/elements/internal/generated/NamedCrate.qll

+1-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/ql/lib/codeql/rust/elements/internal/generated/Raw.qll

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/ql/lib/rust.dbscheme

+1-6
Original file line numberDiff line numberDiff line change
@@ -145,15 +145,10 @@ extractor_step_files(
145145

146146
named_crates(
147147
unique int id: @named_crate,
148+
string name: string ref,
148149
int crate: @crate ref
149150
);
150151

151-
#keyset[id]
152-
named_crate_names(
153-
int id: @named_crate ref,
154-
string name: string ref
155-
);
156-
157152
@unextracted =
158153
@missing
159154
| @unimplemented

rust/schema/prelude.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -124,5 +124,5 @@ class Crate(Locatable):
124124
@qltest.skip
125125
@ql.internal
126126
class NamedCrate(Element):
127-
name: optional[string]
127+
name: string
128128
crate: "Crate"

0 commit comments

Comments
 (0)