Shared: Match line information on Alert and Sink locations. #19354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates inline expectations in various test files to remove the redundant Sink annotations so that only Alert annotations are used for matching line information.
- Removed Sink annotations from ReDoS test files.
- Updated UnsafeShellCommandConstruction test files to reflect only Alert markers.
- Adjusted CommandInjection test files accordingly.
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| javascript/ql/test/query-tests/Security/CWE-400/ReDoS/lib/subLib5/feature.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-400/ReDoS/lib/subLib4/factory.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-400/ReDoS/lib/snapdragon.js | Removed Sink from multiple inline expectation comments. |
| javascript/ql/test/query-tests/Security/CWE-400/ReDoS/lib/otherLib/js/src/index.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-400/ReDoS/lib/moduleLib/moduleLib.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-400/ReDoS/lib/lib.js | Removed Sink from multiple inline expectation comments. |
| javascript/ql/test/query-tests/Security/CWE-400/ReDoS/lib/indirect.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-400/ReDoS/lib/closure.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/subLib4/subsub.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/subLib3/my-file.ts | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/subLib2/special-file.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/subLib2/compiled-file.ts | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/subLib/index.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/subLib/amdSub.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/lib2.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/lib.js | Removed Sink from multiple inline expectation comments. |
| javascript/ql/test/query-tests/Security/CWE-078/UnsafeShellCommandConstruction/lib/isImported.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-078/CommandInjection/exec-sh2.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-078/CommandInjection/exec-sh.js | Removed Sink from inline expectation comment. |
| javascript/ql/test/query-tests/Security/CWE-078/CommandInjection/child_process-test.js | Removed Sink from inline expectation comments in various child_process calls. |
hvitved
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we match line numbers for Alert and Sink locations, such that only Alert needs to be specified.
The change in the inline expectations was made using GitHub Copilot. Furthermore, most of the test cases were also updated automatically using GitHub Copilot (agent mode) in VS Code. However, in some cases it got it wrong - so these were corrected manually.