diff --git a/java/ql/src/Performance/StringReplaceAllWithNonRegex.md b/java/ql/src/Performance/StringReplaceAllWithNonRegex.md index 6e298b4955b6..c7bb609b2c02 100644 --- a/java/ql/src/Performance/StringReplaceAllWithNonRegex.md +++ b/java/ql/src/Performance/StringReplaceAllWithNonRegex.md @@ -18,6 +18,7 @@ public class Test { String s1 = "test"; s1 = s1.replaceAll("t", "x"); // NON_COMPLIANT s1 = s1.replaceAll(".*", "x"); // COMPLIANT + s1 = s1.replace("t", "x"); // COMPLIANT } } diff --git a/java/ql/test/query-tests/StringReplaceAllWithNonRegex/Test.java b/java/ql/test/query-tests/StringReplaceAllWithNonRegex/Test.java index 1465343b8c2e..86711c93de51 100644 --- a/java/ql/test/query-tests/StringReplaceAllWithNonRegex/Test.java +++ b/java/ql/test/query-tests/StringReplaceAllWithNonRegex/Test.java @@ -3,5 +3,6 @@ void f() { String s1 = "test"; s1 = s1.replaceAll("t", "x"); // $ Alert // NON_COMPLIANT s1 = s1.replaceAll(".*", "x"); // COMPLIANT + s1 = s1.replace("t", "x"); // COMPLIANT } }