From 496d856c48215ec03e73c23eb77c30812736607a Mon Sep 17 00:00:00 2001 From: Rasmus Wriedt Larsen Date: Fri, 28 Aug 2020 10:49:33 +0200 Subject: [PATCH] Python: Reformualte explanation of experience from JS --- .../experimental/dataflow/internal/TaintTrackingPrivate.qll | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/ql/src/experimental/dataflow/internal/TaintTrackingPrivate.qll b/python/ql/src/experimental/dataflow/internal/TaintTrackingPrivate.qll index 0f71d2aa92eb..3e32cb8036e1 100644 --- a/python/ql/src/experimental/dataflow/internal/TaintTrackingPrivate.qll +++ b/python/ql/src/experimental/dataflow/internal/TaintTrackingPrivate.qll @@ -36,8 +36,8 @@ predicate localAdditionalTaintStep(DataFlow::Node nodeFrom, DataFlow::Node nodeT * Holds if taint can flow from `nodeFrom` to `nodeTo` with a step related to concatenation. * * Note that since we cannot easily distinguish interesting types (like string, list, tuple), - * we consider any `+` operation to propagate taint. After consulting with the JS team, this - * doesn't sound like it is a big problem in practice. + * we consider any `+` operation to propagate taint. This is what is done in the JS libraries, + * and isn't a big problem in practice. */ predicate concatStep(DataFlow::CfgNode nodeFrom, DataFlow::CfgNode nodeTo) { exists(BinaryExprNode add | add = nodeTo.getNode() |