From 5d55901fc8997a4d04c12a4c98a1322cd7254fc9 Mon Sep 17 00:00:00 2001 From: "Michael B. Gale" Date: Wed, 3 Jan 2024 11:58:43 +0000 Subject: [PATCH 1/2] Use Go 1.22 in workflows --- .github/workflows/__go-tracing-autobuilder.yml | 3 ++- .github/workflows/__go-tracing-custom-build-steps.yml | 3 ++- .github/workflows/__go-tracing-legacy-workflow.yml | 3 ++- pr-checks/checks/go-tracing-autobuilder.yml | 3 ++- pr-checks/checks/go-tracing-custom-build-steps.yml | 3 ++- pr-checks/checks/go-tracing-legacy-workflow.yml | 3 ++- 6 files changed, 12 insertions(+), 6 deletions(-) diff --git a/.github/workflows/__go-tracing-autobuilder.yml b/.github/workflows/__go-tracing-autobuilder.yml index 6e0cbae406..28ff186733 100644 --- a/.github/workflows/__go-tracing-autobuilder.yml +++ b/.github/workflows/__go-tracing-autobuilder.yml @@ -88,7 +88,8 @@ jobs: run: echo "CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT=true" >> $GITHUB_ENV - uses: actions/setup-go@v5 with: - go-version: ~1.21.1 + go-version: ~1.22.0 + cache: false - uses: ./../action/init with: languages: go diff --git a/.github/workflows/__go-tracing-custom-build-steps.yml b/.github/workflows/__go-tracing-custom-build-steps.yml index 97db9e5c68..5fa7524130 100644 --- a/.github/workflows/__go-tracing-custom-build-steps.yml +++ b/.github/workflows/__go-tracing-custom-build-steps.yml @@ -88,7 +88,8 @@ jobs: run: echo "CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT=true" >> $GITHUB_ENV - uses: actions/setup-go@v5 with: - go-version: ~1.21.1 + go-version: ~1.22.0 + cache: false - uses: ./../action/init with: languages: go diff --git a/.github/workflows/__go-tracing-legacy-workflow.yml b/.github/workflows/__go-tracing-legacy-workflow.yml index 2ed8d2adee..65bb400564 100644 --- a/.github/workflows/__go-tracing-legacy-workflow.yml +++ b/.github/workflows/__go-tracing-legacy-workflow.yml @@ -88,7 +88,8 @@ jobs: run: echo "CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT=true" >> $GITHUB_ENV - uses: actions/setup-go@v5 with: - go-version: ~1.21.1 + go-version: ~1.22.0 + cache: false - uses: ./../action/init with: languages: go diff --git a/pr-checks/checks/go-tracing-autobuilder.yml b/pr-checks/checks/go-tracing-autobuilder.yml index 8a1c757821..1ccfb1ecea 100644 --- a/pr-checks/checks/go-tracing-autobuilder.yml +++ b/pr-checks/checks/go-tracing-autobuilder.yml @@ -6,7 +6,8 @@ env: steps: - uses: actions/setup-go@v5 with: - go-version: "~1.21.1" + go-version: "~1.22.0" + cache: false - uses: ./../action/init with: languages: go diff --git a/pr-checks/checks/go-tracing-custom-build-steps.yml b/pr-checks/checks/go-tracing-custom-build-steps.yml index 46d0f07d8c..acdef07a40 100644 --- a/pr-checks/checks/go-tracing-custom-build-steps.yml +++ b/pr-checks/checks/go-tracing-custom-build-steps.yml @@ -4,7 +4,8 @@ operatingSystems: ["ubuntu", "macos"] steps: - uses: actions/setup-go@v5 with: - go-version: "~1.21.1" + go-version: "~1.22.0" + cache: false - uses: ./../action/init with: languages: go diff --git a/pr-checks/checks/go-tracing-legacy-workflow.yml b/pr-checks/checks/go-tracing-legacy-workflow.yml index bdcedf0408..40400bc468 100644 --- a/pr-checks/checks/go-tracing-legacy-workflow.yml +++ b/pr-checks/checks/go-tracing-legacy-workflow.yml @@ -6,7 +6,8 @@ env: steps: - uses: actions/setup-go@v5 with: - go-version: "~1.21.1" + go-version: "~1.22.0" + cache: false - uses: ./../action/init with: languages: go From e3a86ed8b658d657dd6a3c8e0ef2e58460decfda Mon Sep 17 00:00:00 2001 From: "Michael B. Gale" Date: Thu, 22 Feb 2024 17:53:21 +0000 Subject: [PATCH 2/2] Add comment justifying why we set `cache: false` --- .github/workflows/__go-tracing-autobuilder.yml | 2 ++ .github/workflows/__go-tracing-custom-build-steps.yml | 2 ++ .github/workflows/__go-tracing-legacy-workflow.yml | 2 ++ pr-checks/checks/go-tracing-autobuilder.yml | 2 ++ pr-checks/checks/go-tracing-custom-build-steps.yml | 2 ++ pr-checks/checks/go-tracing-legacy-workflow.yml | 2 ++ 6 files changed, 12 insertions(+) diff --git a/.github/workflows/__go-tracing-autobuilder.yml b/.github/workflows/__go-tracing-autobuilder.yml index 28ff186733..5f1c28df3d 100644 --- a/.github/workflows/__go-tracing-autobuilder.yml +++ b/.github/workflows/__go-tracing-autobuilder.yml @@ -89,6 +89,8 @@ jobs: - uses: actions/setup-go@v5 with: go-version: ~1.22.0 + # to avoid potentially misleading autobuilder results where we expect it to download + # dependencies successfully, but they actually come from a warm cache cache: false - uses: ./../action/init with: diff --git a/.github/workflows/__go-tracing-custom-build-steps.yml b/.github/workflows/__go-tracing-custom-build-steps.yml index 5fa7524130..7d55eaa069 100644 --- a/.github/workflows/__go-tracing-custom-build-steps.yml +++ b/.github/workflows/__go-tracing-custom-build-steps.yml @@ -89,6 +89,8 @@ jobs: - uses: actions/setup-go@v5 with: go-version: ~1.22.0 + # to avoid potentially misleading autobuilder results where we expect it to download + # dependencies successfully, but they actually come from a warm cache cache: false - uses: ./../action/init with: diff --git a/.github/workflows/__go-tracing-legacy-workflow.yml b/.github/workflows/__go-tracing-legacy-workflow.yml index 65bb400564..a1e9bb5cee 100644 --- a/.github/workflows/__go-tracing-legacy-workflow.yml +++ b/.github/workflows/__go-tracing-legacy-workflow.yml @@ -89,6 +89,8 @@ jobs: - uses: actions/setup-go@v5 with: go-version: ~1.22.0 + # to avoid potentially misleading autobuilder results where we expect it to download + # dependencies successfully, but they actually come from a warm cache cache: false - uses: ./../action/init with: diff --git a/pr-checks/checks/go-tracing-autobuilder.yml b/pr-checks/checks/go-tracing-autobuilder.yml index 1ccfb1ecea..f5e5a963d6 100644 --- a/pr-checks/checks/go-tracing-autobuilder.yml +++ b/pr-checks/checks/go-tracing-autobuilder.yml @@ -7,6 +7,8 @@ steps: - uses: actions/setup-go@v5 with: go-version: "~1.22.0" + # to avoid potentially misleading autobuilder results where we expect it to download + # dependencies successfully, but they actually come from a warm cache cache: false - uses: ./../action/init with: diff --git a/pr-checks/checks/go-tracing-custom-build-steps.yml b/pr-checks/checks/go-tracing-custom-build-steps.yml index acdef07a40..da0939f19b 100644 --- a/pr-checks/checks/go-tracing-custom-build-steps.yml +++ b/pr-checks/checks/go-tracing-custom-build-steps.yml @@ -5,6 +5,8 @@ steps: - uses: actions/setup-go@v5 with: go-version: "~1.22.0" + # to avoid potentially misleading autobuilder results where we expect it to download + # dependencies successfully, but they actually come from a warm cache cache: false - uses: ./../action/init with: diff --git a/pr-checks/checks/go-tracing-legacy-workflow.yml b/pr-checks/checks/go-tracing-legacy-workflow.yml index 40400bc468..203d779462 100644 --- a/pr-checks/checks/go-tracing-legacy-workflow.yml +++ b/pr-checks/checks/go-tracing-legacy-workflow.yml @@ -7,6 +7,8 @@ steps: - uses: actions/setup-go@v5 with: go-version: "~1.22.0" + # to avoid potentially misleading autobuilder results where we expect it to download + # dependencies successfully, but they actually come from a warm cache cache: false - uses: ./../action/init with: