refine RULE-6-1

jeongsoolee09 · jeongsoolee09 · commit 3e96c5fead7c · 2023-02-01T10:59:04.000-08:00
Use the fact that `resolveTypedefs` is an identity operation with
types that have no type alias (typedef).
diff --git a/c/misra/src/rules/RULE-6-1/BitFieldsShallOnlyBeDeclaredWithAnAppropriateType.ql b/c/misra/src/rules/RULE-6-1/BitFieldsShallOnlyBeDeclaredWithAnAppropriateType.ql
@@ -28,9 +28,6 @@ from BitField bitField
 where
   not isExcluded(bitField,
     BitfieldTypesPackage::bitFieldsShallOnlyBeDeclaredWithAnAppropriateTypeQuery()) and
-  /* A violation would neither an appropriate primitive type nor an appropriate typedef. */
-  not (
-    isAppropriatePrimitive(bitField.getType()) or
-    isAppropriatePrimitive(bitField.getType().resolveTypedefs())
-  )
+  /* A violation would neither be an appropriate primitive type nor an appropriate typedef. */
+  not isAppropriatePrimitive(bitField.getType().resolveTypedefs())
 select bitField, "Bit-field " + bitField + " is declared on type " + bitField.getType() + "."
