Fix compilation error for FIO38 test

mbaluda · mbaluda · commit 55d44f4ed44f · 2023-03-02T11:23:17.000Z
diff --git a/c/cert/test/rules/FIO38-C/DoNotCopyAFileObject.expected b/c/cert/test/rules/FIO38-C/DoNotCopyAFileObject.expected
@@ -1,5 +1,5 @@
-| test.c:10:20:10:26 | * ... | A FILE object is being copied. |
-| test.c:17:21:17:30 | * ... | A FILE object is being copied. |
-| test.c:23:21:23:31 | * ... | A FILE object is being copied. |
-| test.c:29:15:29:21 | * ... | A FILE object is being copied. |
-| test.c:42:19:42:28 | * ... | A FILE object is being copied. |
+| test.c:11:20:11:26 | * ... | A FILE object is being copied. |
+| test.c:18:21:18:30 | * ... | A FILE object is being copied. |
+| test.c:24:21:24:31 | * ... | A FILE object is being copied. |
+| test.c:30:15:30:21 | * ... | A FILE object is being copied. |
+| test.c:43:19:43:28 | * ... | A FILE object is being copied. |
diff --git a/c/cert/test/rules/FIO38-C/DoNotCopyAFileObject.expected.clang b/c/cert/test/rules/FIO38-C/DoNotCopyAFileObject.expected.clang
@@ -0,0 +1,5 @@
+| test.c:4:20:4:26 | * ... | A FILE object is being copied. |
+| test.c:11:21:11:30 | * ... | A FILE object is being copied. |
+| test.c:17:21:17:31 | * ... | A FILE object is being copied. |
+| test.c:23:15:23:21 | * ... | A FILE object is being copied. |
+| test.c:36:19:36:28 | * ... | A FILE object is being copied. |
diff --git a/c/cert/test/rules/FIO38-C/DoNotCopyAFileObject.expected.gcc b/c/cert/test/rules/FIO38-C/DoNotCopyAFileObject.expected.gcc
@@ -0,0 +1,5 @@
+| test.c:4:20:4:26 | * ... | A FILE object is being copied. |
+| test.c:11:21:11:30 | * ... | A FILE object is being copied. |
+| test.c:17:21:17:31 | * ... | A FILE object is being copied. |
+| test.c:23:15:23:21 | * ... | A FILE object is being copied. |
+| test.c:36:19:36:28 | * ... | A FILE object is being copied. |
diff --git a/c/cert/test/rules/FIO38-C/test.c b/c/cert/test/rules/FIO38-C/test.c
@@ -1,4 +1,5 @@
 #include <stdio.h>
+// Workaround for the CodeQL extractor
 #if !defined(__DEFINED_struct__IO_FILE)
 struct _IO_FILE {
   char __x;
diff --git a/c/cert/test/rules/FIO38-C/test.c.clang b/c/cert/test/rules/FIO38-C/test.c.clang
@@ -0,0 +1,43 @@
+#include <stdio.h>
+
+int f1(void) {
+  FILE my_stdout = *stdout; // NON_COMPLIANT
+  return fputs("Hello, World!\n", &my_stdout);
+}
+
+int f2(void) {
+  FILE *my_stdout;
+  my_stdout = stdout;           // COMPLIANT
+  FILE my_stdout2 = *my_stdout; // NON_COMPLIANT
+  return fputs("Hello, World!\n", my_stdout);
+}
+int f2b(void) {
+  FILE *const *my_stdout;
+  my_stdout = &stdout;           // COMPLIANT
+  FILE my_stdout2 = **my_stdout; // NON_COMPLIANT
+  return fputs("Hello, World!\n", *my_stdout);
+}
+
+int f3(void) {
+  FILE my_stdout;
+  my_stdout = *stdout; // NON_COMPLIANT
+  return fputs("Hello, World!\n", &my_stdout);
+}
+
+int f4(void) {
+  FILE *my_stdout;
+  my_stdout = fopen("file.txt", "w"); // COMPLIANT
+  return fputs("Hello, World!\n", my_stdout);
+}
+
+int f5helper(FILE my_stdout) { return fputs("Hello, World!\n", &my_stdout); }
+int f5(void) {
+  FILE *my_stdout = fopen("file.txt", "w"); // COMPLIANT
+  return f5helper(*my_stdout);              // NON_COMPLIANT
+}
+
+int f6helper(FILE *my_stdout) { return fputs("Hello, World!\n", my_stdout); }
+int f6(void) {
+  FILE *my_stdout = fopen("file.txt", "w"); // COMPLIANT
+  return f6helper(my_stdout);               // COMPLIANT
+}
diff --git a/c/cert/test/rules/FIO38-C/test.c.gcc b/c/cert/test/rules/FIO38-C/test.c.gcc
@@ -0,0 +1,43 @@
+#include <stdio.h>
+
+int f1(void) {
+  FILE my_stdout = *stdout; // NON_COMPLIANT
+  return fputs("Hello, World!\n", &my_stdout);
+}
+
+int f2(void) {
+  FILE *my_stdout;
+  my_stdout = stdout;           // COMPLIANT
+  FILE my_stdout2 = *my_stdout; // NON_COMPLIANT
+  return fputs("Hello, World!\n", my_stdout);
+}
+int f2b(void) {
+  FILE *const *my_stdout;
+  my_stdout = &stdout;           // COMPLIANT
+  FILE my_stdout2 = **my_stdout; // NON_COMPLIANT
+  return fputs("Hello, World!\n", *my_stdout);
+}
+
+int f3(void) {
+  FILE my_stdout;
+  my_stdout = *stdout; // NON_COMPLIANT
+  return fputs("Hello, World!\n", &my_stdout);
+}
+
+int f4(void) {
+  FILE *my_stdout;
+  my_stdout = fopen("file.txt", "w"); // COMPLIANT
+  return fputs("Hello, World!\n", my_stdout);
+}
+
+int f5helper(FILE my_stdout) { return fputs("Hello, World!\n", &my_stdout); }
+int f5(void) {
+  FILE *my_stdout = fopen("file.txt", "w"); // COMPLIANT
+  return f5helper(*my_stdout);              // NON_COMPLIANT
+}
+
+int f6helper(FILE *my_stdout) { return fputs("Hello, World!\n", my_stdout); }
+int f6(void) {
+  FILE *my_stdout = fopen("file.txt", "w"); // COMPLIANT
+  return f6helper(my_stdout);               // COMPLIANT
+}

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`#include <stdio.h>`
	`2`	`+// Workaround for the CodeQL extractor`
`2`	`3`	`#if !defined(__DEFINED_struct__IO_FILE)`
`3`	`4`	`struct _IO_FILE {`
`4`	`5`	`char __x;`