Remove aria-haspopup=dialog and add role=button

muan · muan · commit d46cc13c7109 · 2019-05-07T12:40:50.000-04:00
- aria-haspopup=dialog Using NVDA as an example: nvaccess/nvda#8235 - role=button While the default summary role (disclosure triangle) could be appropriate elsewhere, dialog's trigger element should be announced as a button.
diff --git a/index.js b/index.js
@@ -196,7 +196,7 @@ class DetailsDialogElement extends HTMLElement {
 
     const summary = details.querySelector('summary')
     if (summary) {
-      summary.setAttribute('aria-haspopup', 'dialog')
+      summary.setAttribute('role', 'button')
       summary.addEventListener('click', onSummaryClick, {capture: true})
     }
 

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ class DetailsDialogElement extends HTMLElement {`
`196`	`196`
`197`	`197`	`const summary = details.querySelector('summary')`
`198`	`198`	`if (summary) {`
`199`		`- summary.setAttribute('aria-haspopup', 'dialog')`
	`199`	`+ summary.setAttribute('role', 'button')`
`200`	`200`	`summary.addEventListener('click', onSummaryClick, {capture: true})`
`201`	`201`	`}`
`202`	`202`