Skip to content

Commit bde31a1

Browse files
committed
Update test for new event targets
1 parent 4b351a5 commit bde31a1

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

test/test.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -143,14 +143,15 @@ describe('details-menu element', function() {
143143
it('fires events in order', function(done) {
144144
const details = document.querySelector('details')
145145
const summary = details.querySelector('summary')
146+
const menu = details.querySelector('details-menu')
146147
const item = details.querySelector('button')
147148

148-
item.addEventListener('details-menu-select', () => {
149+
menu.addEventListener('details-menu-select', () => {
149150
assert(details.open, 'menu is still open')
150151
assert.equal(summary.textContent, 'Click')
151152
})
152153

153-
item.addEventListener('details-menu-selected', () => {
154+
menu.addEventListener('details-menu-selected', () => {
154155
assert(!details.open, 'menu is closed')
155156
assert.equal(summary.textContent, 'Hubot')
156157
done()
@@ -164,10 +165,11 @@ describe('details-menu element', function() {
164165
it('fires cancellable select event', function(done) {
165166
const details = document.querySelector('details')
166167
const summary = details.querySelector('summary')
168+
const menu = details.querySelector('details-menu')
167169
const item = details.querySelector('button')
168170
let selectedEventCounter = 0
169171

170-
item.addEventListener('details-menu-select', event => {
172+
menu.addEventListener('details-menu-select', event => {
171173
event.preventDefault()
172174
assert(details.open, 'menu is still open')
173175
assert.equal(summary.textContent, 'Click')
@@ -177,7 +179,7 @@ describe('details-menu element', function() {
177179
}, 0)
178180
})
179181

180-
item.addEventListener('details-menu-selected', () => {
182+
menu.addEventListener('details-menu-selected', () => {
181183
selectedEventCounter++
182184
})
183185

@@ -199,7 +201,7 @@ describe('details-menu element', function() {
199201
assert.equal(notDisabled, document.activeElement, 'arrow focuses on the last non-disabled item')
200202

201203
const disabled = details.querySelector('[aria-disabled="true"]')
202-
disabled.addEventListener('details-menu-selected', () => eventCounter++)
204+
document.addEventListener('details-menu-selected', () => eventCounter++, true)
203205
disabled.dispatchEvent(new MouseEvent('click', {bubbles: true}))
204206

205207
assert.equal(eventCounter, 0, 'selected event is not fired')
@@ -216,7 +218,7 @@ describe('details-menu element', function() {
216218
details.dispatchEvent(new KeyboardEvent('keydown', {key: 'ArrowUp'}))
217219

218220
const disabled = details.querySelector('[disabled]')
219-
disabled.addEventListener('details-menu-selected', () => eventCounter++)
221+
document.addEventListener('details-menu-selected', () => eventCounter++, true)
220222
disabled.dispatchEvent(new MouseEvent('click', {bubbles: true}))
221223

222224
assert.equal(eventCounter, 0, 'selected event is not fired')
@@ -309,7 +311,7 @@ describe('details-menu element', function() {
309311
const summary = document.querySelector('summary')
310312
const item = details.querySelector('label')
311313
let eventCounter = 0
312-
details.addEventListener('details-menu-selected', () => eventCounter++)
314+
document.addEventListener('details-menu-selected', () => eventCounter++, true)
313315

314316
summary.dispatchEvent(new MouseEvent('click', {bubbles: true}))
315317
assert(details.open, 'menu opens')

0 commit comments

Comments
 (0)