Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

no-dom-traversal-in-attributechangedcallback recommendation conflicts with no-dom-traversal-in-connectedcallback #46

Closed
khiga8 opened this issue Apr 12, 2022 · 1 comment · Fixed by #47
Closed

no-dom-traversal-in-attributechangedcallback recommendation conflicts with no-dom-traversal-in-connectedcallback #46

khiga8 opened this issue Apr 12, 2022 · 1 comment · Fixed by #47

Comments

@khiga8
Copy link
Contributor

khiga8 commented Apr 12, 2022

no-dom-traversal-in-attributechangedcallback.md states:

It is instead preferable to move such DOM traversals away from attributeChangedCallback, using one of the following:

  • move traversals to connectedCallback

This seems to conflict with no-dom-traversal-in-connectedcallback.md which states Traversing the DOM during the connectedCallback phase is error-prone, which confuses me. it would be helpful to clarify this.
@keithamus
Copy link
Contributor

You're totally right. I think this alternative should be removed entirely, as it doesn't make sense!

@khiga8 khiga8 mentioned this issue Apr 13, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removal of conflicting rec khiga8/eslint-plugin-custom-elements
2 participants
@keithamus @khiga8