fix prefer-for-of violations

koddsson · koddsson · commit 054b28d01d4d · 2020-03-18T16:53:48.000Z
diff --git a/bin/eslint-ignore-errors.js b/bin/eslint-ignore-errors.js
@@ -11,22 +11,22 @@ const fs = require('fs')
 const execFile = require('child_process').execFile
 
 execFile('eslint', ['--format', 'json', process.argv[2]], (error, stdout) => {
-  JSON.parse(stdout).forEach(result => {
+  for (const result of JSON.parse(stdout)) {
     const filename = result.filePath
     const jsLines = fs.readFileSync(filename, 'utf8').split('\n')
     const offensesByLine = {}
     let addedLines = 0
 
     // Produces {47: ['github/no-d-none', 'github/no-blur'], 83: ['github/no-blur']}
-    result.messages.forEach(message => {
+    for (const message of result.messages) {
       if (offensesByLine[message.line]) {
         offensesByLine[message.line].push(message.ruleId)
       } else {
         offensesByLine[message.line] = [message.ruleId]
       }
-    })
+    }
 
-    Object.keys(offensesByLine).forEach(line => {
+    for (const line of Object.keys(offensesByLine)) {
       const lineIndex = line - 1 + addedLines
       const previousLine = jsLines[lineIndex - 1]
       const ruleIds = offensesByLine[line].join(', ')
@@ -37,12 +37,12 @@ execFile('eslint', ['--format', 'json', process.argv[2]], (error, stdout) => {
         jsLines.splice(lineIndex, 0, `${leftPad}/* eslint-disable-next-line ${ruleIds} */`)
       }
       addedLines += 1
-    })
+    }
 
     if (result.messages.length !== 0) {
       fs.writeFileSync(filename, jsLines.join('\n'), 'utf8')
     }
-  })
+  }
 })
 
 function isDisableComment(line) {
diff --git a/bin/npm-check-github-package-requirements.js b/bin/npm-check-github-package-requirements.js
@@ -10,7 +10,7 @@ function check(name, callback) {
 
 function run() {
   process.stdout.write(`1..${checks.length}\n`)
-  checks.forEach(([count, name, callback]) => {
+  for (const [count, name, callback] of checks) {
     Promise.resolve()
       .then(callback)
       .then(() => {
@@ -19,7 +19,7 @@ function run() {
       .catch(error => {
         process.stdout.write(`not ok ${count} - ${name}\n  ${error}\n`)
       })
-  })
+  }
 }
 
 const packageRoot = process.argv[2]
diff --git a/lib/rules/js-class-name.js b/lib/rules/js-class-name.js
@@ -11,11 +11,11 @@ module.exports = {
 
     function checkStringFormat(node, str) {
       const matches = str.match(allJsClassNameRegexp) || []
-      matches.forEach(function(match) {
+      for (const match of matches) {
         if (!match.match(validJsClassNameRegexp)) {
           context.report(node, 'js- class names should be lowercase and only contain dashes.')
         }
-      })
+      }
     }
 
     function checkStringEndsWithJSClassName(node, str) {
@@ -40,13 +40,13 @@ module.exports = {
         }
       },
       TemplateLiteral(node) {
-        node.quasis.forEach(function(quasi) {
+        for (const quasi of node.quasis) {
           checkStringFormat(quasi, quasi.value.raw)
 
           if (quasi.tail === false) {
             checkStringEndsWithJSClassName(quasi, quasi.value.raw)
           }
-        })
+        }
       }
     }
   }
diff --git a/lib/rules/no-implicit-buggy-globals.js b/lib/rules/no-implicit-buggy-globals.js
@@ -9,12 +9,12 @@ module.exports = {
       Program() {
         const scope = context.getScope()
 
-        scope.variables.forEach(function(variable) {
+        for (const variable of scope.variables) {
           if (variable.writeable) {
             return
           }
 
-          variable.defs.forEach(function(def) {
+          for (const def of variable.defs) {
             if (
               def.type === 'FunctionName' ||
               def.type === 'ClassName' ||
@@ -23,8 +23,8 @@ module.exports = {
             ) {
               context.report(def.node, 'Implicit global variable, assign as global property instead.')
             }
-          })
-        })
+          }
+        }
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -11,11 +11,11 @@ module.exports = {`
`11`	`11`
`12`	`12`	`function checkStringFormat(node, str) {`
`13`	`13`	`const matches = str.match(allJsClassNameRegexp) \|\| []`
`14`		`- matches.forEach(function(match) {`
	`14`	`+ for (const match of matches) {`
`15`	`15`	`if (!match.match(validJsClassNameRegexp)) {`
`16`	`16`	`context.report(node, 'js- class names should be lowercase and only contain dashes.')`
`17`	`17`	`}`
`18`		`- })`
	`18`	`+ }`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`function checkStringEndsWithJSClassName(node, str) {`
`@@ -40,13 +40,13 @@ module.exports = {`
`40`	`40`	`}`
`41`	`41`	`},`
`42`	`42`	`TemplateLiteral(node) {`
`43`		`- node.quasis.forEach(function(quasi) {`
	`43`	`+ for (const quasi of node.quasis) {`
`44`	`44`	`checkStringFormat(quasi, quasi.value.raw)`
`45`	`45`
`46`	`46`	`if (quasi.tail === false) {`
`47`	`47`	`checkStringEndsWithJSClassName(quasi, quasi.value.raw)`
`48`	`48`	`}`
`49`		`- })`
	`49`	`+ }`
`50`	`50`	`}`
`51`	`51`	`}`
`52`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,12 +9,12 @@ module.exports = {`
`9`	`9`	`Program() {`
`10`	`10`	`const scope = context.getScope()`
`11`	`11`
`12`		`- scope.variables.forEach(function(variable) {`
	`12`	`+ for (const variable of scope.variables) {`
`13`	`13`	`if (variable.writeable) {`
`14`	`14`	`return`
`15`	`15`	`}`
`16`	`16`
`17`		`- variable.defs.forEach(function(def) {`
	`17`	`+ for (const def of variable.defs) {`
`18`	`18`	`if (`
`19`	`19`	`def.type === 'FunctionName' \|\|`
`20`	`20`	`def.type === 'ClassName' \|\|`
`@@ -23,8 +23,8 @@ module.exports = {`
`23`	`23`	`) {`
`24`	`24`	`context.report(def.node, 'Implicit global variable, assign as global property instead.')`
`25`	`25`	`}`
`26`		`- })`
`27`		`- })`
	`26`	`+ }`
	`27`	`+ }`
`28`	`28`	`}`
`29`	`29`	`}`
`30`	`30`	`}`