remove node config

koddsson · koddsson · commit 3c06626099de · 2020-03-17T17:38:51.000Z
diff --git a/bin/eslint-github-init.js b/bin/eslint-github-init.js
@@ -35,7 +35,7 @@ const questions = [
     type: 'list',
     name: 'env',
     message: 'Which environment does this library target?',
-    choices: ['browser', 'node'],
+    choices: ['browser'],
     default: defaults.env
   },
   {
@@ -50,9 +50,7 @@ const questions = [
 inquirer.prompt(questions).then(answers => {
   const eslintrc = {extends: ['plugin:github/es6']}
 
-  if (answers.env === 'node') {
-    eslintrc.extends.push('plugin:github/node')
-  } else if (answers.project === 'app') {
+  if (answers.project === 'app') {
     eslintrc.extends.push('plugin:github/app')
   } else if (answers.env === 'browser') {
     eslintrc.extends.push('plugin:github/browser')
diff --git a/docs/configs.md b/docs/configs.md
@@ -29,7 +29,3 @@ Recommended rules when using Babel to transpile features from ES2015+.
 ### `plugin:github/app`
 
 Recommended rules when writing a browser application.
-
-### `plugin:github/node`
-
-Recommended rules when writing a node application.
diff --git a/lib/configs/node.js b/lib/configs/node.js
diff --git a/lib/index.js b/lib/index.js
@@ -21,7 +21,6 @@ module.exports = {
     app: require('./configs/app'),
     browser: require('./configs/browser'),
     es6: require('./configs/es6'),
-    node: require('./configs/node'),
     recommended: require('./configs/recommended'),
     typescript: require('./configs/typescript')
   }
diff --git a/package.json b/package.json
@@ -28,9 +28,6 @@
     "url": "https://github.com/github/eslint-plugin-github/issues"
   },
   "homepage": "https://github.com/github/eslint-plugin-github#readme",
-  "engines": {
-    "node": ">=8.11.1"
-  },
   "dependencies": {
     "@typescript-eslint/eslint-plugin": ">=2.5.0",
     "@typescript-eslint/parser": ">=2.5.0",

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@ module.exports = {`
`21`	`21`	`app: require('./configs/app'),`
`22`	`22`	`browser: require('./configs/browser'),`
`23`	`23`	`es6: require('./configs/es6'),`
`24`		`- node: require('./configs/node'),`
`25`	`24`	`recommended: require('./configs/recommended'),`
`26`	`25`	`typescript: require('./configs/typescript')`
`27`	`26`	`}`