Skip to content

Commit 8c21392

Browse files
authored
Merge pull request #146 from github/upstream-changes
Cleanup
2 parents 319365e + 2892e64 commit 8c21392

File tree

6 files changed

+106
-20
lines changed

6 files changed

+106
-20
lines changed

.flowconfig

-11
This file was deleted.

.prettierignore

-2
This file was deleted.

lib/configs/browser.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@ module.exports = {
22
env: {
33
browser: true
44
},
5-
plugins: ['github'],
5+
plugins: ['github', 'escompat'],
6+
extends: ['plugin:escompat/recommended', 'plugin:escompat/typescript'],
67
rules: {
8+
'escompat/no-dynamic-imports': 'off',
79
'github/async-currenttarget': 'error',
810
'github/async-preventdefault': 'error',
911
'github/get-attribute': 'error',

lib/configs/typescript.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ module.exports = {
1414
'@typescript-eslint/no-use-before-define': 'off',
1515
'@typescript-eslint/explicit-member-accessibility': 'off',
1616
'@typescript-eslint/explicit-function-return-type': 'off',
17-
'@typescript-eslint/no-non-null-assertion': 'off'
17+
'@typescript-eslint/no-non-null-assertion': 'off',
18+
'@typescript-eslint/no-unused-vars': 'error',
19+
'@typescript-eslint/explicit-module-boundary-types': 'off'
1820
}
1921
}

package-lock.json

+99-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
"@typescript-eslint/eslint-plugin": "^5.1.0",
2929
"@typescript-eslint/parser": "^5.1.0",
3030
"eslint-config-prettier": ">=8.0.0",
31+
"eslint-plugin-escompat": "^3.1.0",
3132
"eslint-plugin-eslint-comments": "^3.2.0",
3233
"eslint-plugin-filenames": "^1.3.2",
3334
"eslint-plugin-i18n-text": "^1.0.1",
@@ -50,7 +51,6 @@
5051
"@github/prettier-config": "0.0.4",
5152
"eslint": "^8.0.1",
5253
"eslint-plugin-eslint-plugin": "^2.3.0",
53-
"eslint-visitor-keys": "^2.0.0",
5454
"globals": "^13.7.0",
5555
"mocha": "^8.3.2"
5656
}

0 commit comments

Comments
 (0)