refactor: clean up and remove unnecessary allocations in stdio server initialization

gillisandrew · gillisandrew · commit 82fdeac50124 · 2025-04-11T21:26:41.000Z
diff --git a/cmd/github-mcp-server/main.go b/cmd/github-mcp-server/main.go
@@ -120,28 +120,23 @@ func runStdioServer(cfg runConfig) error {
 		host = viper.GetString("gh-host")
 	}
 
-	// Check if a token is set
-	token := os.Getenv("GITHUB_PERSONAL_ACCESS_TOKEN")
-
-	// Create GH client
-	ghClientOptions := api.ClientOptions{
+	// Create GitHub API client
+	httpClient, err := api.NewHTTPClient(api.ClientOptions{
 		Host:      host,
-		AuthToken: token,
-	}
-
-	httpClient, err := api.NewHTTPClient(ghClientOptions)
+		AuthToken: os.Getenv("GITHUB_PERSONAL_ACCESS_TOKEN"),
+	})
 	if err != nil {
-		return fmt.Errorf("failed to create GitHub client: %w", err)
+		return fmt.Errorf("failed to create client: %w", err)
 	}
 	ghClient := gogithub.NewClient(httpClient)
 	ghClient.UserAgent = fmt.Sprintf("github-mcp-server/%s", version)
 
-	t, dumpTranslations := translations.TranslationHelper()
-
 	getClient := func(_ context.Context) (*gogithub.Client, error) {
 		return ghClient, nil // closing over client
 	}
-	// Create
+
+	// Create MCP server
+	t, dumpTranslations := translations.TranslationHelper()
 	ghServer := github.NewServer(getClient, version, cfg.readOnly, t)
 	stdioServer := server.NewStdioServer(ghServer)
 
