refactor: fix sliding

mattdholloway · mattdholloway · commit e6ef962e18c8 · 2025-08-12T17:06:45.000+01:00
diff --git a/pkg/github/actions.go b/pkg/github/actions.go
@@ -754,11 +754,6 @@ func downloadLogContent(logURL string, tailLines int) (string, int, *http.Respon
 		return "", 0, httpResp, fmt.Errorf("failed to download logs: HTTP %d", httpResp.StatusCode)
 	}
 
-	// content, err := io.ReadAll(httpResp.Body)
-	// if err != nil {
-	// 	return "", 0, httpResp, fmt.Errorf("failed to read log content: %w", err)
-	// }
-
 	if tailLines <= 0 {
 		tailLines = 1000
 	}
@@ -774,7 +769,7 @@ func downloadLogContent(logURL string, tailLines int) (string, int, *http.Respon
 		lines = append(lines, line)
 
 		if len(lines) > tailLines {
-			lines = lines[len(lines)-tailLines:]
+			lines = lines[1:]
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -754,11 +754,6 @@ func downloadLogContent(logURL string, tailLines int) (string, int, *http.Respon`
`754`	`754`	`return "", 0, httpResp, fmt.Errorf("failed to download logs: HTTP %d", httpResp.StatusCode)`
`755`	`755`	`}`
`756`	`756`
`757`		`- // content, err := io.ReadAll(httpResp.Body)`
`758`		`- // if err != nil {`
`759`		`- // return "", 0, httpResp, fmt.Errorf("failed to read log content: %w", err)`
`760`		`- // }`
`761`		`-`
`762`	`757`	`if tailLines <= 0 {`
`763`	`758`	`tailLines = 1000`
`764`	`759`	`}`
`@@ -774,7 +769,7 @@ func downloadLogContent(logURL string, tailLines int) (string, int, *http.Respon`
`774`	`769`	`lines = append(lines, line)`
`775`	`770`
`776`	`771`	`if len(lines) > tailLines {`
`777`		`- lines = lines[len(lines)-tailLines:]`
	`772`	`+ lines = lines[1:]`
`778`	`773`	`}`
`779`	`774`	`}`
`780`	`775`