From 051a7f468c178e52e27e918e727b045621f66345 Mon Sep 17 00:00:00 2001 From: Liu YuanYuan Date: Fri, 27 Dec 2019 16:02:46 +0800 Subject: [PATCH 1/3] Update index.d.ts Use the right way to add custom element to TypeScript definitions. Sadly, I didn't find any official docs on this matter, only some posts/repos: - https://justinfagnani.com/2019/11/01/how-to-publish-web-components-to-npm/ - https://github.com/runem/lit-analyzer/tree/master/packages/lit-analyzer#-no-unknown-tag-name --- index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.d.ts b/index.d.ts index d6384f6..1fe4154 100644 --- a/index.d.ts +++ b/index.d.ts @@ -4,7 +4,7 @@ export default class ImageCropElement extends HTMLElement { } declare global { - interface Window { - ImageCropElement: typeof ImageCropElement + interface HTMLElementTagNameMap { + 'image-crop': ImageCropElement } } From 1ee42456838c53aa87464d3f12d3776c6ecc9e91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Mon, 6 Jan 2020 11:48:33 +0000 Subject: [PATCH 2/3] include window definition to ts definition file --- index.d.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/index.d.ts b/index.d.ts index 1fe4154..dd82947 100644 --- a/index.d.ts +++ b/index.d.ts @@ -4,6 +4,9 @@ export default class ImageCropElement extends HTMLElement { } declare global { + interface Window { + ImageCropElement: typeof ImageCropElement + } interface HTMLElementTagNameMap { 'image-crop': ImageCropElement } From 5c7909784213529bebc159a6ec55cb4e5a4b05d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Mon, 20 Jan 2020 12:52:01 +0000 Subject: [PATCH 3/3] 3.0.7 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index c5392c9..8814785 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "@github/image-crop-element", - "version": "3.0.6", + "version": "3.0.7", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 605badb..967086c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@github/image-crop-element", - "version": "3.0.6", + "version": "3.0.7", "description": "Select area for cropping an image. This does not actually crop.", "main": "dist/index.umd.js", "module": "dist/index.esm.js",