Switch Promise chaining to async-await syntax. #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make future PRs like #81 easier to author and review.
|
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.
|
dgraham
reviewed
Oct 28, 2022
Co-authored-by: David Graham <david.malcom.graham@gmail.com>
|
It seems this failed CI when merging. I'e been taking occasional pokes at it to figure out why, and it occurred to me today to try https://github.com/github/include-fragment-element/actions/runs/3363846846/jobs/5577516226 failed with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make future PRs like #81 easier to author and review.
The functionality (and published build compat) should be exactly the same, so the existing tests should cover this change.