Make list behaviors more consistent, fix list stacking #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 88b1a76.
Improve code readability Co-Authored-By: Chris Westra <cwestra@gmail.com>
koddsson
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to make list behaviors more consistent and also fixes list stacking.
List stacking
List behavior
This PR aims to make the behavior of ordered and unordered lists more consistent.
We now always consider the whole line instead of relying on selection or caret position.
If no text is selected, the current caret position is retained (that is also true for when undoing a list).
If text is selected, the whole line that was considered for the operation will be selected after the operation is complete.
This resolves an inconsistency between ordered and unordered lists, where creating a ordered list would split a line at the caret position, while an unordered list would not:
I tried to add as much test coverage as I could think of and adjusted the existing tests to the new behavior.
This fixes https://github.com/github/special-projects/issues/598 and supersedes #52