simplified implementation to only support keyBy based on string key

zashraf1985 · zashraf1985 · commit 1fea09312154 · 2020-02-20T18:41:26.000-08:00
diff --git a/packages/optimizely-sdk/lib/utils/fns/index.js b/packages/optimizely-sdk/lib/utils/fns/index.js
@@ -1,5 +1,5 @@
 /**
- * Copyright 2017, 2019, Optimizely
+ * Copyright 2017, 2019-2020, Optimizely
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -30,14 +30,11 @@ module.exports = {
   isFinite: function(number) {
     return _isFinite(number) && Math.abs(number) <= MAX_NUMBER_LIMIT;
   },
-  keyBy: function(arr, callback) {
+  keyBy: function(arr, key) {
     if (!arr) return {};
-    if (typeof callback === 'string' || callback instanceof String) {
-      return keyBy(arr, function(item) {
-        return item[callback];
-      });
-    }
-    return keyBy(arr, callback);
+    return keyBy(arr, function(item) {
+      return item[key];
+    });
   },
   forEach: require('lodash/forEach'),
   forOwn: require('lodash/forOwn'),
diff --git a/packages/optimizely-sdk/lib/utils/fns/index.tests.js b/packages/optimizely-sdk/lib/utils/fns/index.tests.js
@@ -37,27 +37,8 @@ describe('lib/utils/fns', function() {
         assert.isTrue(fns.isFinite(-Math.pow(2, 53)));
       });
     });
+    
     describe('keyBy', function() {
-      it('should return correct object if callback is a function', function() {
-        var arr = [
-          { key1: 'row1', key2: 'key2row1' },
-          { key1: 'row2', key2: 'key2row2' },
-          { key1: 'row3', key2: 'key2row3' },
-          { key1: 'row4', key2: 'key2row4' },
-        ];
-
-        var obj = fns.keyBy(arr, function(item) {
-          return item['key1'];
-        });
-
-        assert.deepEqual(obj, {
-          row1: { key1: 'row1', key2: 'key2row1' },
-          row2: { key1: 'row2', key2: 'key2row2' },
-          row3: { key1: 'row3', key2: 'key2row3' },
-          row4: { key1: 'row4', key2: 'key2row4' }
-        });
-      });
-
       it('should return correct object if callback is a string key', function() {
         var arr = [
           { key1: 'row1', key2: 'key2row1' },
@@ -75,7 +56,7 @@ describe('lib/utils/fns', function() {
           row4: { key1: 'row4', key2: 'key2row4' }
         });
       });
-
+      
       it('should return empty object when first argument is null or undefined', function() {
         var obj = fns.keyBy(null, 'key1');
         assert.isEmpty(obj);
