Merge branch 'master' into zeeshan/replace-lodash-keyby

zashraf1985 · web-flow · commit 3706300ebdc2 · 2020-02-24T09:49:36.000-08:00
diff --git a/packages/optimizely-sdk/lib/utils/fns/index.js b/packages/optimizely-sdk/lib/utils/fns/index.js
@@ -40,5 +40,7 @@ module.exports = {
     return uuid.v4();
   },
   values: require('lodash/values'),
-  isNumber: require('lodash/isNumber'),
+  isNumber: function(value) {
+    return typeof value === 'number';
+  },
 };
diff --git a/packages/optimizely-sdk/lib/utils/fns/index.tests.js b/packages/optimizely-sdk/lib/utils/fns/index.tests.js
@@ -63,6 +63,24 @@ describe('lib/utils/fns', function() {
 
         obj = fns.keyBy(undefined, 'key1');
         assert.isEmpty(obj);
+        });
+    });
+    
+    describe('isNumber', function() {
+      it('should return true in case of number', function() {
+        assert.isTrue(fns.isNumber(3));
+      });
+      it('should return true in case of value from Number object ', function() {
+        assert.isTrue(fns.isNumber(Number.MIN_VALUE));
+      });
+      it('should return true in case of Infinity ', function() {
+        assert.isTrue(fns.isNumber(Infinity));
+      });
+      it('should return false in case of string', function() {
+        assert.isFalse(fns.isNumber('3'));
+      });
+      it('should return false in case of null', function() {
+        assert.isFalse(fns.isNumber(null));
       });
     });
   });
