Support lerna commands with clean/build scripts

jasonkarns · jasonkarns · commit 50343542ce19 · 2020-05-08T17:33:07.000-04:00
The top-level package defined clean and build scripts that were expected
to run the (surprise!) clean and build steps of each package. However,
most packages named their build step 'tsc' instead of 'build', and
virtually none of them had 'clean' as a separate step.
diff --git a/packages/datafile-manager/package.json b/packages/datafile-manager/package.json
@@ -55,11 +55,13 @@
     "@react-native-community/async-storage": "^1.2.0"
   },
   "scripts": {
+    "clean": "rm -rf lib",
     "lint": "tsc --noEmit && eslint --fix 'src/**/*.ts' '__test__/**/*.ts'",
     "test": "jest",
     "posttest": "npm run lint",
-    "tsc": "rm -rf lib && tsc",
-    "prepare": "npm run tsc",
+    "prebuild": "npm run clean",
+    "build": "tsc",
+    "prepare": "npm run build",
     "prepublishOnly": "npm test"
   }
 }
diff --git a/packages/event-processor/package.json b/packages/event-processor/package.json
@@ -19,9 +19,11 @@
     "package.json"
   ],
   "scripts": {
-    "tsc": "rm -rf lib && tsc",
+    "clean": "rm -rf lib",
+    "prebuild": "npm run clean",
+    "build": "tsc",
     "test": "jest",
-    "prepare": "npm run tsc",
+    "prepare": "npm run build",
     "prepublishOnly": "npm test"
   },
   "repository": {
diff --git a/packages/logging/package.json b/packages/logging/package.json
@@ -19,9 +19,11 @@
     "package.json"
   ],
   "scripts": {
-    "tsc": "rm -rf lib && tsc",
+    "clean": "rm -rf lib",
+    "prebuild": "npm run clean",
+    "build": "tsc",
     "test": "jest",
-    "prepare": "npm run tsc",
+    "prepare": "npm run build",
     "prepublishOnly": "npm test"
   },
   "repository": {
diff --git a/packages/optimizely-sdk/package.json b/packages/optimizely-sdk/package.json
@@ -8,13 +8,15 @@
   "react-native": "dist/optimizely.react_native.min.js",
   "typings": "lib/index.d.ts",
   "scripts": {
+    "clean": "rm -rf dist",
     "lint": "eslint 'lib/**/*.js'",
     "test": "mocha ./lib/*.tests.js ./lib/**/*.tests.js ./lib/**/**/*tests.js --recursive --exit --require esm --require lib/tests/exit_on_unhandled_rejection.js",
     "test-ci": "npm run test-xbrowser && npm run test-umdbrowser",
     "test-xbrowser": "karma start karma.bs.conf.js --single-run",
     "test-umdbrowser": "npm run build-browser-umd && karma start karma.umd.conf.js --single-run",
     "build-browser-umd": "rollup -c --environment BUILD_UMD_BUNDLE",
-    "build": "rm -rf dist && rollup -c --environment BUILD_ALL",
+    "prebuild": "npm run clean",
+    "build": "rollup -c --environment BUILD_ALL",
     "cover": "istanbul cover _mocha ./lib/*.tests.js ./lib/**/*.tests.js ./lib/**/**/*tests.js",
     "coveralls": "npm run cover -- --report lcovonly && cat ./coverage/lcov.info | coveralls",
     "prepare": "npm run build",
diff --git a/packages/utils/package.json b/packages/utils/package.json
@@ -19,9 +19,11 @@
     "package.json"
   ],
   "scripts": {
-    "tsc": "rm -rf lib && tsc",
+    "clean": "rm -rf lib",
+    "prebuild": "npm run clean",
+    "build": "tsc",
     "test": "jest",
-    "prepare": "npm run tsc",
+    "prepare": "npm run build",
     "prepublishOnly": "npm test"
   },
   "repository": {
