fix: feature enabled will now only be available when experiment is feature experiment (optimizely#384)

zashraf1985 · mjc1283 · commit 6fa9cd03166f · 2020-01-08T08:29:10.000-08:00
OptimizelyConfig was using featureEnabled directly from projectConfig Object without verifying if experiment is feature experiment or not. Now featureEnabled key on variation will only be available if experiment is a feature experiment.
diff --git a/packages/optimizely-sdk/lib/core/optimizely_config/index.js b/packages/optimizely-sdk/lib/core/optimizely_config/index.js
@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+var projectConfig = require('../project_config');
 
 // Get Experiment Ids which are part of rollouts
 function getRolloutExperimentIds(rollouts) {
@@ -41,9 +42,11 @@ function getExperimentsMap(configObj) {
           variations[variation.key] = {
             id: variation.id,
             key: variation.key,
-            featureEnabled: variation.featureEnabled,
             variablesMap: getMergedVariablesMap(configObj, variation, experiment.id, featureVariablesMap)
           };
+          if (projectConfig.isFeatureExperiment(configObj, experiment.id)) {
+            variations[variation.key].featureEnabled = variation.featureEnabled;
+          }
           return variations;
         }, {}),
       };
