getEnabledFeatures returns sorted feature-keys. (optimizely#80)

mfahadahmed · mikeproeng37 · commit 7e11082b974a · 2018-03-16T14:24:42.000-07:00
diff --git a/packages/optimizely-sdk-core/lib/optimizely/index.js b/packages/optimizely-sdk-core/lib/optimizely/index.js
@@ -516,7 +516,7 @@ Optimizely.prototype.getEnabledFeatures = function(userId, attributes) {
     }
   }.bind(this));
 
-  return enabledFeatures;
+  return enabledFeatures.sort();
 };
 
 /**
diff --git a/packages/optimizely-sdk-core/lib/optimizely/index.tests.js b/packages/optimizely-sdk-core/lib/optimizely/index.tests.js
@@ -2837,6 +2837,35 @@ describe('lib/optimizely', function() {
           attributes
         );
       });
+
+      it('returns sorted feature-key list', function() {
+        var sortedFeatures = [
+          'feature_with_group',
+          'shared_feature',
+          'test_feature',
+          'test_feature_2',
+          'test_feature_for_experiment',
+          'unused_flag'
+        ];
+
+        sandbox.restore();
+        sandbox.stub(optlyInstance, 'isFeatureEnabled', function(featureKey) {
+          return sortedFeatures.indexOf(featureKey) !== -1;
+        });
+        var attributes = { test_attribute: 'test_value' };
+        var result = optlyInstance.getEnabledFeatures('user1', attributes);
+        assert.deepEqual(sortedFeatures, result);
+        sinon.assert.callCount(optlyInstance.isFeatureEnabled, 6);
+
+        sinon.assert.callOrder(
+          optlyInstance.isFeatureEnabled.withArgs('test_feature', 'user1', attributes),
+          optlyInstance.isFeatureEnabled.withArgs('test_feature_2', 'user1', attributes),
+          optlyInstance.isFeatureEnabled.withArgs('test_feature_for_experiment', 'user1', attributes),
+          optlyInstance.isFeatureEnabled.withArgs('feature_with_group', 'user1', attributes),
+          optlyInstance.isFeatureEnabled.withArgs('shared_feature', 'user1', attributes),
+          optlyInstance.isFeatureEnabled.withArgs('unused_flag', 'user1', attributes)
+        );
+      });
     });
 
     describe('feature variable APIs', function() {

Original file line number	Diff line number	Diff line change
`@@ -516,7 +516,7 @@ Optimizely.prototype.getEnabledFeatures = function(userId, attributes) {`
`516`	`516`	`}`
`517`	`517`	`}.bind(this));`
`518`	`518`
`519`		`- return enabledFeatures;`
	`519`	`+ return enabledFeatures.sort();`
`520`	`520`	`};`
`521`	`521`
`522`	`522`	`/**`