Remove version constraints for rubocop libraries

composerinteralia · composerinteralia · commit 286944a59e9b · 2022-01-11T14:31:47.000-05:00
These constraints make it more difficult to upgrade these libraries in projects that use rubocop-github. I think the idea here was that we'd be able to bump the version alongside the default config, but without locking to an exact version we can still end up with a config that is incompatible with certain rubocop version (see the unrecognized cop error in #86, for example). If anything, I'd prefer a `>=` constraint over a `<=`. That would allow us to bump the minimum constraint when we add new cops, but still freely upgrade in our projects as long as there are no config incompatibilities (which are less common anyway ever since RuboCop 1.0).
diff --git a/rubocop-github.gemspec b/rubocop-github.gemspec
@@ -10,9 +10,9 @@ Gem::Specification.new do |s|
 
   s.files = Dir["README.md", "STYLEGUIDE.md", "LICENSE", "config/*.yml", "lib/**/*.rb", "guides/*.md"]
 
-  s.add_dependency "rubocop", "<= 1.13.0"
-  s.add_dependency "rubocop-performance", "<= 1.11.0"
-  s.add_dependency "rubocop-rails", "<= 2.7.1"
+  s.add_dependency "rubocop"
+  s.add_dependency "rubocop-performance"
+  s.add_dependency "rubocop-rails"
 
   s.add_development_dependency "actionview", "~> 5.0"
   s.add_development_dependency "minitest", "~> 5.14"
